From e85fadd66b9fe54a702c96ce6fd3bf39a06f682d Mon Sep 17 00:00:00 2001 From: OVVO-Financial <18292393+OVVO-Financial@users.noreply.github.com> Date: Mon, 15 Jun 2026 15:51:51 +0000 Subject: [PATCH] Parity review reports for R NNS 3c03a9c9d183fee06e2e8b718d2a0f4d7f45c153 --- changed_files.json | 5 ++++- sync/last_live_r_parity_report.md | 7 +++---- sync/last_r_api_inspection.md | 9 ++++++++- sync/last_r_api_plan.json | 11 ++++++++--- upstream/NNS | 2 +- 5 files changed, 24 insertions(+), 10 deletions(-) diff --git a/changed_files.json b/changed_files.json index 2baefa4e..545db9e9 100644 --- a/changed_files.json +++ b/changed_files.json @@ -1,3 +1,6 @@ [ - "R/ARMA.R" + "R/ARMA.R", + "R/RcppExports.R", + "src/RcppExports.cpp", + "src/internal_functions.cpp" ] diff --git a/sync/last_live_r_parity_report.md b/sync/last_live_r_parity_report.md index 09eb22d7..9ef9f3fd 100644 --- a/sync/last_live_r_parity_report.md +++ b/sync/last_live_r_parity_report.md @@ -6,9 +6,8 @@ - Skip install: `False` - Live R recompute: `True` -## Result: live R parity diverged +## Result: manual review required -Mapped parity tests recomputed every R value from the freshly installed live R NNS and the Python implementation did not match. Public Python behavior differs from live R at the recorded commit. +The plan reports unmapped R files. A human must extend `sync/r_api_map.json` before automated parity can run: -Failing command: `/opt/hostedtoolcache/Python/3.11.15/x64/bin/python -m pytest -q -n 0 tests/parity/test_practical_examples.py tests/parity/test_r13_smoke.py` -Exit status: `1` +- `R/RcppExports.R` diff --git a/sync/last_r_api_inspection.md b/sync/last_r_api_inspection.md index 79defb7a..eb890c5e 100644 --- a/sync/last_r_api_inspection.md +++ b/sync/last_r_api_inspection.md @@ -3,6 +3,9 @@ ## Changed files - `R/ARMA.R` +- `R/RcppExports.R` +- `src/RcppExports.cpp` +- `src/internal_functions.cpp` ## Affected Python modules @@ -23,4 +26,8 @@ - Fresh cache required: `False` - Export review required: `False` -- Unmapped R files present: `False` +- Unmapped R files present: `True` + +## Unmapped R files + +- `R/RcppExports.R` diff --git a/sync/last_r_api_plan.json b/sync/last_r_api_plan.json index 6fef8d57..9ac489bf 100644 --- a/sync/last_r_api_plan.json +++ b/sync/last_r_api_plan.json @@ -1,6 +1,9 @@ { "changed_files": [ - "R/ARMA.R" + "R/ARMA.R", + "R/RcppExports.R", + "src/RcppExports.cpp", + "src/internal_functions.cpp" ], "affected_python_modules": [ "src/nns/arma.py" @@ -16,7 +19,9 @@ ], "requires_fresh_cache": false, "requires_export_review": false, - "has_unmapped_r_files": false, - "unmapped_r_files": [], + "has_unmapped_r_files": true, + "unmapped_r_files": [ + "R/RcppExports.R" + ], "warnings": [] } diff --git a/upstream/NNS b/upstream/NNS index 7250bb62..3c03a9c9 160000 --- a/upstream/NNS +++ b/upstream/NNS @@ -1 +1 @@ -Subproject commit 7250bb627d12f6cdb1dbe60a8b8e50385e2a7c41 +Subproject commit 3c03a9c9d183fee06e2e8b718d2a0f4d7f45c153