diff --git a/changed_files.json b/changed_files.json index 2baefa4e..b132985d 100644 --- a/changed_files.json +++ b/changed_files.json @@ -1,3 +1,5 @@ [ - "R/ARMA.R" + "R/Partition_Map.R", + "src/NNS_part.cpp", + "tests/testthat/test_NNS_reg_infinite.R" ] diff --git a/sync/last_live_r_parity_report.md b/sync/last_live_r_parity_report.md index 09eb22d7..b5d385e9 100644 --- a/sync/last_live_r_parity_report.md +++ b/sync/last_live_r_parity_report.md @@ -3,12 +3,17 @@ - Plan: `sync/last_r_api_plan.json` - R checkout: `upstream/NNS` - Fresh cache requested: `False` -- Skip install: `False` -- Live R recompute: `True` +- Skip install: `True` +- Live R recompute: `False` -## Result: live R parity diverged +## Result: manual review required -Mapped parity tests recomputed every R value from the freshly installed live R NNS and the Python implementation did not match. Public Python behavior differs from live R at the recorded commit. +The plan reports unmapped R files. A human must extend `sync/r_api_map.json` before automated parity can run: -Failing command: `/opt/hostedtoolcache/Python/3.11.15/x64/bin/python -m pytest -q -n 0 tests/parity/test_practical_examples.py tests/parity/test_r13_smoke.py` -Exit status: `1` +- `R/Partition_Map.R` + +## Workflow step outcome + +- `run_live_r_parity_for_changed_api.py` step outcome: `failure` +- Fresh cache requested: `false` +- DESCRIPTION changed: `false` diff --git a/sync/last_r_api_inspection.md b/sync/last_r_api_inspection.md index 79defb7a..b4ad3913 100644 --- a/sync/last_r_api_inspection.md +++ b/sync/last_r_api_inspection.md @@ -2,25 +2,28 @@ ## Changed files -- `R/ARMA.R` +- `R/Partition_Map.R` +- `src/NNS_part.cpp` +- `tests/testthat/test_NNS_reg_infinite.R` ## Affected Python modules -- `src/nns/arma.py` +- None mapped ## Parity tests to run -- `tests/parity/test_practical_examples.py` -- `tests/parity/test_r13_smoke.py` +- None mapped ## Cache scope -- `NNS.ARMA` -- `NNS.ARMA.optim` -- `NNS.VAR` +- None mapped ## Required actions - Fresh cache required: `False` - Export review required: `False` -- Unmapped R files present: `False` +- Unmapped R files present: `True` + +## Unmapped R files + +- `R/Partition_Map.R` diff --git a/sync/last_r_api_plan.json b/sync/last_r_api_plan.json index 6fef8d57..d024b65d 100644 --- a/sync/last_r_api_plan.json +++ b/sync/last_r_api_plan.json @@ -1,22 +1,17 @@ { "changed_files": [ - "R/ARMA.R" - ], - "affected_python_modules": [ - "src/nns/arma.py" - ], - "parity_tests": [ - "tests/parity/test_practical_examples.py", - "tests/parity/test_r13_smoke.py" - ], - "cache_scope": [ - "NNS.ARMA", - "NNS.ARMA.optim", - "NNS.VAR" + "R/Partition_Map.R", + "src/NNS_part.cpp", + "tests/testthat/test_NNS_reg_infinite.R" ], + "affected_python_modules": [], + "parity_tests": [], + "cache_scope": [], "requires_fresh_cache": false, "requires_export_review": false, - "has_unmapped_r_files": false, - "unmapped_r_files": [], + "has_unmapped_r_files": true, + "unmapped_r_files": [ + "R/Partition_Map.R" + ], "warnings": [] } diff --git a/upstream/NNS b/upstream/NNS index 7250bb62..cf18e19a 160000 --- a/upstream/NNS +++ b/upstream/NNS @@ -1 +1 @@ -Subproject commit 7250bb627d12f6cdb1dbe60a8b8e50385e2a7c41 +Subproject commit cf18e19a8ab2584b5369857fdcda59ef3a864ec5