From fd8788b23350a83c34d23c64d03098edc262f791 Mon Sep 17 00:00:00 2001 From: OVVO-Financial <18292393+OVVO-Financial@users.noreply.github.com> Date: Mon, 13 Jul 2026 08:23:39 +0000 Subject: [PATCH] Parity review reports for R NNS 15d74ef047d5c60cda53dfa8ca6db13c96ad3f6d --- sync/last_live_r_parity_report.md | 8 +++---- sync/last_r_api_inspection.md | 40 ++++++++++++++++++++++++++----- sync/last_r_api_plan.json | 40 +++++++++++++++++++++++++------ 3 files changed, 71 insertions(+), 17 deletions(-) diff --git a/sync/last_live_r_parity_report.md b/sync/last_live_r_parity_report.md index 09eb22d7..16507600 100644 --- a/sync/last_live_r_parity_report.md +++ b/sync/last_live_r_parity_report.md @@ -6,9 +6,9 @@ - Skip install: `False` - Live R recompute: `True` -## Result: live R parity diverged +## Result: manual review required -Mapped parity tests recomputed every R value from the freshly installed live R NNS and the Python implementation did not match. Public Python behavior differs from live R at the recorded commit. +The plan reports unmapped R files. A human must extend `sync/r_api_map.json` before automated parity can run: -Failing command: `/opt/hostedtoolcache/Python/3.11.15/x64/bin/python -m pytest -q -n 0 tests/parity/test_practical_examples.py tests/parity/test_r13_smoke.py` -Exit status: `1` +- `R/Multivariate_Regression.R` +- `R/RcppExports.R` diff --git a/sync/last_r_api_inspection.md b/sync/last_r_api_inspection.md index 79defb7a..94d49fd6 100644 --- a/sync/last_r_api_inspection.md +++ b/sync/last_r_api_inspection.md @@ -2,25 +2,53 @@ ## Changed files -- `R/ARMA.R` +- `R/Multivariate_Regression.R` +- `R/RcppExports.R` +- `R/Regression.R` +- `R/Stack.R` +- `benchmarks/benchmark_stack_native.R` +- `benchmarks/stack_baseline_report.md` +- `benchmarks/stack_baseline_results.csv` +- `benchmarks/stack_native_report.md` +- `benchmarks/stack_native_results.csv` +- `src/NNS_mreg_predict.cpp` +- `src/NNS_mreg_setup.cpp` +- `src/NNS_stack_fast.cpp` +- `src/RcppExports.cpp` +- `tests/testthat/helper-stack-parity.R` +- `tests/testthat/test-mreg-path-native.R` +- `tests/testthat/test-mreg-setup-native.R` +- `tests/testthat/test-stack-method1-native-parity.R` +- `tests/testthat/test-stack-method2-native-parity.R` +- `tests/testthat/test-stack-native-parity.R` +- `tests/testthat/test-univariate-fast-parity.R` +- `tests/testthat/test-xstar-path-native.R` ## Affected Python modules -- `src/nns/arma.py` +- `src/nns/multivariate_regression.py` +- `src/nns/regression.py` +- `src/nns/stack.py` ## Parity tests to run +- `tests/docs/test_vignette_examples.py` - `tests/parity/test_practical_examples.py` - `tests/parity/test_r13_smoke.py` ## Cache scope -- `NNS.ARMA` -- `NNS.ARMA.optim` -- `NNS.VAR` +- `NNS.M.reg` +- `NNS.reg` +- `NNS.stack` ## Required actions - Fresh cache required: `False` - Export review required: `False` -- Unmapped R files present: `False` +- Unmapped R files present: `True` + +## Unmapped R files + +- `R/Multivariate_Regression.R` +- `R/RcppExports.R` diff --git a/sync/last_r_api_plan.json b/sync/last_r_api_plan.json index 6fef8d57..dcea89d8 100644 --- a/sync/last_r_api_plan.json +++ b/sync/last_r_api_plan.json @@ -1,22 +1,48 @@ { "changed_files": [ - "R/ARMA.R" + "R/Multivariate_Regression.R", + "R/RcppExports.R", + "R/Regression.R", + "R/Stack.R", + "benchmarks/benchmark_stack_native.R", + "benchmarks/stack_baseline_report.md", + "benchmarks/stack_baseline_results.csv", + "benchmarks/stack_native_report.md", + "benchmarks/stack_native_results.csv", + "src/NNS_mreg_predict.cpp", + "src/NNS_mreg_setup.cpp", + "src/NNS_stack_fast.cpp", + "src/RcppExports.cpp", + "tests/testthat/helper-stack-parity.R", + "tests/testthat/test-mreg-path-native.R", + "tests/testthat/test-mreg-setup-native.R", + "tests/testthat/test-stack-method1-native-parity.R", + "tests/testthat/test-stack-method2-native-parity.R", + "tests/testthat/test-stack-native-parity.R", + "tests/testthat/test-univariate-fast-parity.R", + "tests/testthat/test-xstar-path-native.R" ], "affected_python_modules": [ - "src/nns/arma.py" + "src/nns/multivariate_regression.py", + "src/nns/regression.py", + "src/nns/stack.py" ], "parity_tests": [ + "tests/docs/test_vignette_examples.py", "tests/parity/test_practical_examples.py", "tests/parity/test_r13_smoke.py" ], "cache_scope": [ - "NNS.ARMA", - "NNS.ARMA.optim", - "NNS.VAR" + "NNS.M.reg", + "NNS.reg", + "NNS.stack" ], "requires_fresh_cache": false, "requires_export_review": false, - "has_unmapped_r_files": false, - "unmapped_r_files": [], + "has_unmapped_r_files": true, + "unmapped_r_files": [ + "R/Multivariate_Regression.R", + "R/RcppExports.R" + ], "warnings": [] }