fix(cre-main): rename misspelled variable pending_stadards to pending_standards

Author: BEAST04289

application/cmd/cre_main.py

@@ -277,8 +277,8 @@ def register_standard(
         # calculate gap analysis
         populate_neo4j_db(db_connection_str)
         jobs = []
-        pending_stadards = collection.standards()
-        for standard_name in pending_stadards:
+        pending_standards = collection.standards()
+        for standard_name in pending_standards:
             if standard_name == importing_name:
                 continue
 
@@ -293,9 +293,9 @@ def register_standard(
                     jobs.append(forward_job)
                 except exceptions.NoSuchJobError as nje:
                     logger.error(
-                        f"Could not find gap analysis job for for {importing_name} and {standard_name} putting {standard_name} back in the queue"
+                        f"Could not find gap analysis job for {importing_name} and {standard_name} putting {standard_name} back in the queue"
                     )
-                    pending_stadards.append(standard_name)
+                    pending_standards.append(standard_name)
 
             bw_key = gap_analysis.make_resources_key([standard_name, importing_name])
             if not collection.gap_analysis_exists(bw_key):
@@ -308,9 +308,9 @@ def register_standard(
                     jobs.append(backward_job)
                 except exceptions.NoSuchJobError as nje:
                     logger.error(
-                        f"Could not find gap analysis job for for {importing_name} and {standard_name} putting {standard_name} back in the queue"
+                        f"Could not find gap analysis job for {importing_name} and {standard_name} putting {standard_name} back in the queue"
                     )
-                    pending_stadards.append(standard_name)
+                    pending_standards.append(standard_name)
         redis.wait_for_jobs(jobs)
         conn.set(standard_hash, value="")
 

application/database/db.py

@@ -995,7 +995,7 @@ def get_by_tags(self, tags: List[str]) -> List[cre_defs.Document]:
                 documents.extend(resolved)
             else:
                 logger.fatal(
-                    "db.get_node returned None for "
+                    "get_nodes() returned no documents for "
                     "Node %s:%s:%s that exists, BUG!"
                     % (db_node.name, db_node.section, db_node.section_id)
                 )

application/tests/db_test.py

@@ -125,6 +125,26 @@ def test_get_by_tags(self) -> None:
         self.assertEqual(self.collection.get_by_tags([]), [])
         self.assertEqual(self.collection.get_by_tags(["this should not be a tag"]), [])
 
+    @patch("application.database.db.logger")
+    def test_get_by_tags_empty_nodes_regression(self, mock_logger) -> None:
+        """
+        Simulate get_nodes returning an empty list to test the error path in get_by_tags.
+        See PR #837 regression fix.
+        """
+        dbstandard = db.Node(
+            section="regression_section",
+            name="regression_name",
+            tags="regression_tag",
+            ntype=defs.Standard.__name__,
+        )
+        self.collection.session.add(dbstandard)
+        self.collection.session.commit()
+
+        with patch.object(self.collection, "get_nodes", return_value=[]):
+            res = self.collection.get_by_tags(["regression_tag"])
+            self.assertEqual(res, [])
+            mock_logger.fatal.assert_called_once()
+
     def test_get_standards_names(self) -> None:
         result = self.collection.get_node_names()
         expected = [("Standard", "BarStand"), ("Standard", "Unlinked")]