test_get_cre_csv and test_import_from_cre_csv always return 404 because ENABLE_MYOPENCRE is never set in tests

[shiwani42]

What is the issue?

ENABLE_MYOPENCRE is imported as a plain boolean at module load time in web_main.py. Both /rest/v1/cre_csv and /rest/v1/cre_csv_import abort with 404 when it is False. The tests never patch this value, so both routes are permanently unreachable in the test environment and the CSV functionality has no test coverage.

Expected Behaviour

Both tests should reach the route handlers and validate the CSV functionality.

Actual Behaviour

AssertionError: 200 != 404 for both test_get_cre_csv and test_import_from_cre_csv.

Steps to reproduce

1. Run the test suite: flask test
2. Observe the failures on test_get_cre_csv and test_import_from_cre_csv in web_main_test.py

[shiwani42]

Hi @Pa04rth, is this a valid issue? Happy to raise a PR if so.

[Pa04rth]

Go ahead

[PRAteek-singHWY]

Hi @shiwani42,

Adding one small follow-up point here since I worked on MyOpenCRE and the gap-analysis optimization flow earlier.
There are a couple of related improvements that could be considered while resolving this issue.

Alongside the current test issue in #871, ENABLE_MYOPENCRE is still read at import time and then reused by /api/capabilities and the MyOpenCRE CSV routes, and I noticed a similar pattern around GAP_ANALYSIS_OPTIMIZED as well.

A practical example is local development after cloning the repo: if the app starts once with MyOpenCRE disabled and ENABLE_MYOPENCRE is enabled later, the capability and route behavior still follow the startup-time value until restart, which can be confusing and can also make flag-based tests more brittle.

If needed, I’d be happy to discuss it further in the same thread.

Thank you @Pa04rth for suggesting this.