Two small issues in the skipped manifest dependencies feature added in #841.
1. Dead null guard in renderSkippedDependenciesSection
src/output/html-reporter.ts line with the early return:
if (!skipped || skipped.length === 0) return "";
skipped is typed string[] (non-optional), so !skipped can never be true. The guard should be:
if (skipped.length === 0) return "";
As written, it implies the argument could be null or undefined, which misleads anyone reading it alongside the type signature.
2. Icon collision - two ⊘ sections in the same report
renderSkippedSection (the existing "Skipped findings" card) already uses ⊘. The new renderSkippedDependenciesSection also uses ⊘, so a report that has both sections will show two visually identical ⊘ headers for different concepts - fix-plan exclusions vs. unresolvable manifest specifiers.
The new section should use a distinct symbol (e.g. ⊖) so users can tell the two sections apart at a glance.
Two small issues in the skipped manifest dependencies feature added in #841.
1. Dead null guard in
renderSkippedDependenciesSectionsrc/output/html-reporter.tsline with the early return:skippedis typedstring[](non-optional), so!skippedcan never be true. The guard should be:As written, it implies the argument could be
nullorundefined, which misleads anyone reading it alongside the type signature.2. Icon collision - two
⊘sections in the same reportrenderSkippedSection(the existing "Skipped findings" card) already uses⊘. The newrenderSkippedDependenciesSectionalso uses⊘, so a report that has both sections will show two visually identical⊘headers for different concepts - fix-plan exclusions vs. unresolvable manifest specifiers.The new section should use a distinct symbol (e.g.
⊖) so users can tell the two sections apart at a glance.