capture submenu causes unleash

[Pyhrn]

What version of OpenCollar are you using?
8.3

What behavior did you expect?
Collar wearer stays leashed

What behavior did you see instead?
Collar wearer gets unleashed

What steps does someone need to take to reproduce the problem?
Leash wearer, go to Apps -> Capture, any of the four buttons (including 'BACK') will unleash the wearer.

[Medea-Destiny]

@Pyhrn Thank you for the bug report!

This appears to be happening in the commit() function at line 270. This function is used for all status changes, including both saving settings changes and starting/stopping capture. An unleash command is sent with CMD_OWNER auth level if capture is not active (g_iActive is FALSE) with the obvious intention of unleashing when a capture ends, but it means that when settings are saved, an unleash is sent with owner level permission. Commit should be separated into two functions, one for saving settings only and the other for handling a change of capture status.