Typemaker 1.1 Rebased Redux#2313
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| public DreamPath GetLastCommonAncestor(DMCompiler compiler, DreamPath other) { | ||
| var thisObject = compiler.DMObjectTree.GetOrCreateDMObject(this); | ||
| var otherObject = compiler.DMObjectTree.GetOrCreateDMObject(other); |
Check warning
Code scanning / InspectCode
Expression is always false according to nullable reference types' annotations Warning
|
|
||
| public DreamPath GetLastCommonAncestor(DMCompiler compiler, DreamPath other) { | ||
| var thisObject = compiler.DMObjectTree.GetOrCreateDMObject(this); | ||
| var otherObject = compiler.DMObjectTree.GetOrCreateDMObject(other); |
Check warning
Code scanning / InspectCode
Expression is always false according to nullable reference types' annotations Warning
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This uses quite a few hacky solutions (like I don't think this is mergeable in its current state. It would be ideal if this could be split up into multiple PRs so the problematic changes can be worked on more effectively and the non-problematic ones can be merged in. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
2 participants
Essentially just revives #2208 with some key differences:
as paramsat all. This PR is large enough as-is and I don't want to figure out the passing aroundprocParametersmessastype()in typemakerImplicitNullTypefor proc argsNote that passing the
--skip-anything-typecheckcompiler option is still strongly recommended for trying to actually use typemaker.Also don't forget to elevate the typemaker pragmas to warnings/errors for this to actually do anything.
Future PR things:
alist()supportas paramsfrom the original PR