From 43484022fc30970ac6c68d702b395d7c73159bef Mon Sep 17 00:00:00 2001 From: David Leong <116610336+leongdl@users.noreply.github.com> Date: Thu, 23 Jul 2026 08:34:53 -0700 Subject: [PATCH] =?UTF-8?q?test:=20Add=20=C2=A73.4=20list-form=20range-cap?= =?UTF-8?q?=20and=20=C2=A77.3.1=20Step.Name=20job=20fixtures?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Four fixtures pinning create-time and run-time behavior that no existing fixture covered, updated for the §3.4.1.1.1 spec fix (IntRangeExpr expansion is uncapped; only the form carries the 1024 cap): - 3.4--range-from-list-param-at-limit.test: exactly 1024 list-resolved range elements must be accepted (list-form cap, accept side). - 3.4--range-from-list-param-too-long.invalid.test: a supplied LIST[INT] of 1025 items through a typed whole-field range "{{Param.Values}}" is decode-clean but must fail at job creation (list-form cap, reject side). - 3.4--range-expr-supplied-value-beyond-list-cap.test: a supplied RANGE_EXPR "1-1025" must be ACCEPTED and run 1025 tasks — IntRangeExpr expansion is explicitly unconstrained by the spec (3.4.1.1.1). Replaces the earlier .invalid fixture, which pre-dated the spec fix and asserted the opposite. - 7.3.1--step-name-in-step-environment.test: Step.Name resolves in a step environment's onEnter/onExit, directly and via step-level let. Review: quorum-review fixes — corrected RFC citations (whole-field resolution is RFC 0005 / Expression Language 1.3.2, not RFC 0006; Step.Name is RFC 0005, not RFC 0007) and scoped all cap language to the list form. Signed-off-by: David Leong <116610336+leongdl@users.noreply.github.com> --- ...r-supplied-value-beyond-list-cap.test.yaml | 39 ++++++++++++++++ ...--range-from-list-param-at-limit.test.yaml | 39 ++++++++++++++++ ...from-list-param-too-long.invalid.test.yaml | 32 ++++++++++++++ ...1--step-name-in-step-environment.test.yaml | 44 +++++++++++++++++++ 4 files changed, 154 insertions(+) create mode 100644 conformance-tests/2023-09/EXPR/jobs/3.4--range-expr-supplied-value-beyond-list-cap.test.yaml create mode 100644 conformance-tests/2023-09/EXPR/jobs/3.4--range-from-list-param-at-limit.test.yaml create mode 100644 conformance-tests/2023-09/EXPR/jobs/3.4--range-from-list-param-too-long.invalid.test.yaml create mode 100644 conformance-tests/2023-09/EXPR/jobs/7.3.1--step-name-in-step-environment.test.yaml diff --git a/conformance-tests/2023-09/EXPR/jobs/3.4--range-expr-supplied-value-beyond-list-cap.test.yaml b/conformance-tests/2023-09/EXPR/jobs/3.4--range-expr-supplied-value-beyond-list-cap.test.yaml new file mode 100644 index 0000000..cd21db1 --- /dev/null +++ b/conformance-tests/2023-09/EXPR/jobs/3.4--range-expr-supplied-value-beyond-list-cap.test.yaml @@ -0,0 +1,39 @@ +# Template Schemas 3.4.1.1.1: the number of values an expands +# to "is not constrained by this specification" — the 1024-element cap in +# 3.4.1.1 applies only to the literal form. A user-SUPPLIED +# RANGE_EXPR value of "1-1025" therefore expands to 1025 tasks and job +# creation must SUCCEED. (The capped list form is pinned by the +# 3.4--range-from-list-param-* pair; the static-template analog of this +# accept is mainline's 3.4--wide-int-range-expression.yaml.) +# +# Note: this test runs 1025 (trivial) tasks — a few seconds on the Rust CLI, +# ~3 minutes on the Python CLI (one subprocess per task). +template: + specificationVersion: jobtemplate-2023-09 + extensions: + - EXPR + name: TestJob + parameterDefinitions: + - name: Frames + type: RANGE_EXPR + steps: + - name: Step1 + parameterSpace: + taskParameterDefinitions: + - name: Frame + type: INT + range: "{{RawParam.Frames}}" + script: + actions: + onRun: + command: python + args: + - -c + - print(r'TASK:{{Task.Param.Frame}}:END') +parameters: + Frames: "1-1025" +expected: + output: + - TASK:1:END + - TASK:1024:END + - TASK:1025:END diff --git a/conformance-tests/2023-09/EXPR/jobs/3.4--range-from-list-param-at-limit.test.yaml b/conformance-tests/2023-09/EXPR/jobs/3.4--range-from-list-param-at-limit.test.yaml new file mode 100644 index 0000000..ff8373c --- /dev/null +++ b/conformance-tests/2023-09/EXPR/jobs/3.4--range-from-list-param-at-limit.test.yaml @@ -0,0 +1,39 @@ +# Template Schemas 3.4.1.1: the (list) form of a task +# parameter range must not exceed 1024 elements — exactly 1024 must be +# accepted. (Only the list form is capped; expansion is +# explicitly uncapped per 3.4.1.1.1.) The range comes from a supplied +# LIST[INT] via RFC 0005 / Expression Language 1.3.2 typed whole-field +# resolution, so this pins the job-creation boundary of the list-form cap +# (its rejection side is 3.4--range-from-list-param-too-long). +# +# Note: this test runs 1024 (trivial) tasks — a few seconds on the Rust CLI, +# ~3 minutes on the Python CLI (one subprocess per task). It exists to guard +# the exact off-by-one an at-the-cap rejection bug would introduce. +template: + specificationVersion: jobtemplate-2023-09 + extensions: + - EXPR + name: TestJob + parameterDefinitions: + - name: Values + type: LIST[INT] + steps: + - name: Step1 + parameterSpace: + taskParameterDefinitions: + - name: V + type: INT + range: "{{Param.Values}}" + script: + actions: + onRun: + command: python + args: + - -c + - print(r'TASK:{{Task.Param.V}}') +parameters: + Values: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540, 541, 542, 543, 544, 545, 546, 547, 548, 549, 550, 551, 552, 553, 554, 555, 556, 557, 558, 559, 560, 561, 562, 563, 564, 565, 566, 567, 568, 569, 570, 571, 572, 573, 574, 575, 576, 577, 578, 579, 580, 581, 582, 583, 584, 585, 586, 587, 588, 589, 590, 591, 592, 593, 594, 595, 596, 597, 598, 599, 600, 601, 602, 603, 604, 605, 606, 607, 608, 609, 610, 611, 612, 613, 614, 615, 616, 617, 618, 619, 620, 621, 622, 623, 624, 625, 626, 627, 628, 629, 630, 631, 632, 633, 634, 635, 636, 637, 638, 639, 640, 641, 642, 643, 644, 645, 646, 647, 648, 649, 650, 651, 652, 653, 654, 655, 656, 657, 658, 659, 660, 661, 662, 663, 664, 665, 666, 667, 668, 669, 670, 671, 672, 673, 674, 675, 676, 677, 678, 679, 680, 681, 682, 683, 684, 685, 686, 687, 688, 689, 690, 691, 692, 693, 694, 695, 696, 697, 698, 699, 700, 701, 702, 703, 704, 705, 706, 707, 708, 709, 710, 711, 712, 713, 714, 715, 716, 717, 718, 719, 720, 721, 722, 723, 724, 725, 726, 727, 728, 729, 730, 731, 732, 733, 734, 735, 736, 737, 738, 739, 740, 741, 742, 743, 744, 745, 746, 747, 748, 749, 750, 751, 752, 753, 754, 755, 756, 757, 758, 759, 760, 761, 762, 763, 764, 765, 766, 767, 768, 769, 770, 771, 772, 773, 774, 775, 776, 777, 778, 779, 780, 781, 782, 783, 784, 785, 786, 787, 788, 789, 790, 791, 792, 793, 794, 795, 796, 797, 798, 799, 800, 801, 802, 803, 804, 805, 806, 807, 808, 809, 810, 811, 812, 813, 814, 815, 816, 817, 818, 819, 820, 821, 822, 823, 824, 825, 826, 827, 828, 829, 830, 831, 832, 833, 834, 835, 836, 837, 838, 839, 840, 841, 842, 843, 844, 845, 846, 847, 848, 849, 850, 851, 852, 853, 854, 855, 856, 857, 858, 859, 860, 861, 862, 863, 864, 865, 866, 867, 868, 869, 870, 871, 872, 873, 874, 875, 876, 877, 878, 879, 880, 881, 882, 883, 884, 885, 886, 887, 888, 889, 890, 891, 892, 893, 894, 895, 896, 897, 898, 899, 900, 901, 902, 903, 904, 905, 906, 907, 908, 909, 910, 911, 912, 913, 914, 915, 916, 917, 918, 919, 920, 921, 922, 923, 924, 925, 926, 927, 928, 929, 930, 931, 932, 933, 934, 935, 936, 937, 938, 939, 940, 941, 942, 943, 944, 945, 946, 947, 948, 949, 950, 951, 952, 953, 954, 955, 956, 957, 958, 959, 960, 961, 962, 963, 964, 965, 966, 967, 968, 969, 970, 971, 972, 973, 974, 975, 976, 977, 978, 979, 980, 981, 982, 983, 984, 985, 986, 987, 988, 989, 990, 991, 992, 993, 994, 995, 996, 997, 998, 999, 1000, 1001, 1002, 1003, 1004, 1005, 1006, 1007, 1008, 1009, 1010, 1011, 1012, 1013, 1014, 1015, 1016, 1017, 1018, 1019, 1020, 1021, 1022, 1023] +expected: + output: + - TASK:0 + - TASK:1023 diff --git a/conformance-tests/2023-09/EXPR/jobs/3.4--range-from-list-param-too-long.invalid.test.yaml b/conformance-tests/2023-09/EXPR/jobs/3.4--range-from-list-param-too-long.invalid.test.yaml new file mode 100644 index 0000000..2e7cd23 --- /dev/null +++ b/conformance-tests/2023-09/EXPR/jobs/3.4--range-from-list-param-too-long.invalid.test.yaml @@ -0,0 +1,32 @@ +# Template Schemas 3.4.1.1: the (list) form of a task +# parameter range must not contain more than 1024 elements. (Only the list +# form is capped; expansion is explicitly uncapped per +# 3.4.1.1.1.) The cap applies at job creation for ranges produced by +# RFC 0005 / Expression Language 1.3.2 typed whole-field resolution too: +# here the range is "{{Param.Values}}" and the user-SUPPLIED LIST[INT] +# value has 1025 items, so the template passes static validation but job +# creation must fail. +template: + specificationVersion: jobtemplate-2023-09 + extensions: + - EXPR + name: TestJob + parameterDefinitions: + - name: Values + type: LIST[INT] + steps: + - name: Step1 + parameterSpace: + taskParameterDefinitions: + - name: V + type: INT + range: "{{Param.Values}}" + script: + actions: + onRun: + command: python + args: + - -c + - print() +parameters: + Values: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540, 541, 542, 543, 544, 545, 546, 547, 548, 549, 550, 551, 552, 553, 554, 555, 556, 557, 558, 559, 560, 561, 562, 563, 564, 565, 566, 567, 568, 569, 570, 571, 572, 573, 574, 575, 576, 577, 578, 579, 580, 581, 582, 583, 584, 585, 586, 587, 588, 589, 590, 591, 592, 593, 594, 595, 596, 597, 598, 599, 600, 601, 602, 603, 604, 605, 606, 607, 608, 609, 610, 611, 612, 613, 614, 615, 616, 617, 618, 619, 620, 621, 622, 623, 624, 625, 626, 627, 628, 629, 630, 631, 632, 633, 634, 635, 636, 637, 638, 639, 640, 641, 642, 643, 644, 645, 646, 647, 648, 649, 650, 651, 652, 653, 654, 655, 656, 657, 658, 659, 660, 661, 662, 663, 664, 665, 666, 667, 668, 669, 670, 671, 672, 673, 674, 675, 676, 677, 678, 679, 680, 681, 682, 683, 684, 685, 686, 687, 688, 689, 690, 691, 692, 693, 694, 695, 696, 697, 698, 699, 700, 701, 702, 703, 704, 705, 706, 707, 708, 709, 710, 711, 712, 713, 714, 715, 716, 717, 718, 719, 720, 721, 722, 723, 724, 725, 726, 727, 728, 729, 730, 731, 732, 733, 734, 735, 736, 737, 738, 739, 740, 741, 742, 743, 744, 745, 746, 747, 748, 749, 750, 751, 752, 753, 754, 755, 756, 757, 758, 759, 760, 761, 762, 763, 764, 765, 766, 767, 768, 769, 770, 771, 772, 773, 774, 775, 776, 777, 778, 779, 780, 781, 782, 783, 784, 785, 786, 787, 788, 789, 790, 791, 792, 793, 794, 795, 796, 797, 798, 799, 800, 801, 802, 803, 804, 805, 806, 807, 808, 809, 810, 811, 812, 813, 814, 815, 816, 817, 818, 819, 820, 821, 822, 823, 824, 825, 826, 827, 828, 829, 830, 831, 832, 833, 834, 835, 836, 837, 838, 839, 840, 841, 842, 843, 844, 845, 846, 847, 848, 849, 850, 851, 852, 853, 854, 855, 856, 857, 858, 859, 860, 861, 862, 863, 864, 865, 866, 867, 868, 869, 870, 871, 872, 873, 874, 875, 876, 877, 878, 879, 880, 881, 882, 883, 884, 885, 886, 887, 888, 889, 890, 891, 892, 893, 894, 895, 896, 897, 898, 899, 900, 901, 902, 903, 904, 905, 906, 907, 908, 909, 910, 911, 912, 913, 914, 915, 916, 917, 918, 919, 920, 921, 922, 923, 924, 925, 926, 927, 928, 929, 930, 931, 932, 933, 934, 935, 936, 937, 938, 939, 940, 941, 942, 943, 944, 945, 946, 947, 948, 949, 950, 951, 952, 953, 954, 955, 956, 957, 958, 959, 960, 961, 962, 963, 964, 965, 966, 967, 968, 969, 970, 971, 972, 973, 974, 975, 976, 977, 978, 979, 980, 981, 982, 983, 984, 985, 986, 987, 988, 989, 990, 991, 992, 993, 994, 995, 996, 997, 998, 999, 1000, 1001, 1002, 1003, 1004, 1005, 1006, 1007, 1008, 1009, 1010, 1011, 1012, 1013, 1014, 1015, 1016, 1017, 1018, 1019, 1020, 1021, 1022, 1023, 1024] diff --git a/conformance-tests/2023-09/EXPR/jobs/7.3.1--step-name-in-step-environment.test.yaml b/conformance-tests/2023-09/EXPR/jobs/7.3.1--step-name-in-step-environment.test.yaml new file mode 100644 index 0000000..d63553d --- /dev/null +++ b/conformance-tests/2023-09/EXPR/jobs/7.3.1--step-name-in-step-environment.test.yaml @@ -0,0 +1,44 @@ +# Template Schemas 7.3.1 (Step.Name is defined by RFC 0005; the section +# number is the Template Schemas wiki's): Step.Name is available to a +# step's environments at run +# time — both directly and through step-level `let` bindings, in the +# environment's onEnter and onExit alike. (Static acceptance is pinned by +# job_templates/7.3.1--step-name-in-step-environment.yaml; the negative +# polarity — Step.Name unavailable in job environments — by the +# 7.3.1--step-name-in-job-environment*.invalid fixtures.) +template: + specificationVersion: jobtemplate-2023-09 + extensions: + - EXPR + name: TestJob + steps: + - name: EchoStepName + let: + - banner = 'step-is-' + Step.Name + stepEnvironments: + - name: NameEcho + script: + actions: + onEnter: + command: python + args: + - -c + - "print(r'ENTER_DIRECT:{{ Step.Name }}')\nprint(r'ENTER_LET:{{ banner }}')" + onExit: + command: python + args: + - -c + - "print(r'EXIT_LET:{{ banner }}')" + script: + actions: + onRun: + command: python + args: + - -c + - print(r'TASK:{{ Step.Name }}') +expected: + output: + - ENTER_DIRECT:EchoStepName + - ENTER_LET:step-is-EchoStepName + - TASK:EchoStepName + - EXIT_LET:step-is-EchoStepName