Skip to content

refactor(domain): migrate TeamSeasonRecord to LoL (remove draws) #53

Description

@NicoRuedaA

Problem or opportunity

TeamSeasonRecord in domain/src/team.rs contains football-specific concepts that do not exist in League of Legends:

  • drawn: u32 — LoL has no draws (series are Bo1/Bo3/Bo5 with clear winner)
  • goals_for: u32 — should be maps_won
  • goals_against: u32 — should be maps_lost

Proposed solution

  1. Remove drawn field entirely.
  2. Rename goals_for → maps_won.
  3. Rename goals_against → maps_lost.
  4. Add serde aliases for backwards compatibility.

UX impact

  • Standings table currently shows draws and goals — must switch to maps won/lost.
  • Season review screen affected.

Acceptance criteria

  • drawn field removed from TeamSeasonRecord
  • goals_for renamed to maps_won with alias
  • goals_against renamed to maps_lost with alias
  • UI updated to show maps instead of goals/draws
  • Standings calculation updated (no draw points)

Scope

Data / provenance

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions