From c37a3a9cdde80ef42cb046655850e59e65375988 Mon Sep 17 00:00:00 2001 From: Franck Michea Date: Tue, 19 May 2026 17:22:54 +0200 Subject: [PATCH] fix: Pacman provider uses unrecognized option '--update' In cf789b7a708f51eb6f6d7db1294eaa543b7805c7, long command parameters were introduced for readability. Command argument ``-U`` was changed to ``--update`` but as can be seen in the previous commit description the actual replacement for this shorthand is ``--upgrade``. Signed-off-by: Franck Michea --- lib/puppet/provider/package/pacman.rb | 2 +- spec/unit/provider/package/pacman_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/puppet/provider/package/pacman.rb b/lib/puppet/provider/package/pacman.rb index 6c93851e52..e4c5b7d832 100644 --- a/lib/puppet/provider/package/pacman.rb +++ b/lib/puppet/provider/package/pacman.rb @@ -248,7 +248,7 @@ def install_from_file else fail _("Source %{source} is not supported by pacman") % { source: source } end - pacman "--noconfirm", "--noprogressbar", "--update", source + pacman "--noconfirm", "--noprogressbar", "--upgrade", source end def install_from_repo diff --git a/spec/unit/provider/package/pacman_spec.rb b/spec/unit/provider/package/pacman_spec.rb index 4d88d2e4d9..62128fe3cd 100644 --- a/spec/unit/provider/package/pacman_spec.rb +++ b/spec/unit/provider/package/pacman_spec.rb @@ -98,7 +98,7 @@ resource[:source] = source expect(executor).to receive(:execute). - with(include("--update") & include(source), no_extra_options). + with(include("--upgrade") & include(source), no_extra_options). ordered. and_return("") @@ -116,7 +116,7 @@ it "should install from the path segment of the URL" do expect(executor).to receive(:execute). - with(include("--update") & include(actual_file_path), no_extra_options). + with(include("--upgrade") & include(actual_file_path), no_extra_options). ordered. and_return("")