[LOW] — Service layer is largely untested; only `app.controller.spec.ts` exists across the entire `src/` tree

[ibrahimmosouf-png]

Severity: Low
Type: Testing
Scope: Repository-wide
Labels: testing, help wanted, Official Campaign

Description

A repository-wide search for *.spec.ts files confirms a single test file exists: src/app.controller.spec.ts. None of the services (DonationsService, CampaignsService, MilestonesService, UsersService, AdminService, StellarTransactionsService, SorobanService, NotificationsService, EmailService, StellarEventService) have unit tests. The e2e/ directory contains only app.e2e-spec.ts with no positive test coverage.

Given the complexity of the donation + campaign balance + refund flows (issues #1, #2, #8, #12, #15), the absence of regression tests materially increases the cost of safe changes.

Recommendation

• Cover the highest-risk service modules first: DonationsService, CampaignsService, MilestonesService, StellarTransactionsService, SorobanService. Mock prisma and Horizon/Soroban RPC.
• Add e2e tests for POST /campaigns, POST /donations, POST /api-keys, and GET /campaigns/:id/stats.
• Wire these into CI (see [LOW] — No CI pipeline: lint, format, build and tests are not run automatically; regressions ship undetected #18) and enforce a minimum coverage threshold (e.g. --coverageThreshold='{"global":{"lines":70,"functions":70,"branches":60,"statements":70}}').

---

[Adeolu01]

Hello miantainer, I'm a fullstack engr. and I have accessed this issue and I can resolve it. Please assign this issue to me.

[grantfox-oss]

🦊 GrantFox — @Adeolu01 has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #20)
2. Your PR will be reviewed by the OrbitChainLabs maintainers

Good luck! Track your progress on GrantFox.

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign campaign!

@Adeolu01's PR #27 was approved and merged by @Alqku.

🏆 @Adeolu01: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (48 total points). Track your full progress on GrantFox.

👏 Great work, @Adeolu01! Keep contributing to OrbitChainLabs.