From 2a8f922883b84dc902bfda1440542ccd57defaf7 Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Thu, 19 Nov 2026 02:11:41 +0200 Subject: [PATCH] =?UTF-8?q?=D7=A1=D7=A4=D7=A8=D7=99=D7=90:=20=D7=A7=D7=99?= =?UTF-8?q?=D7=A9=D7=95=D7=A8=20=D7=A4=D7=99=D7=A8=D7=95=D7=A9=20=D7=9C?= =?UTF-8?q?=D7=A1=D7=A2=D7=99=D7=A3=20=D7=A9=D7=9C=D7=9D=20=D7=A0=D7=A9?= =?UTF-8?q?=D7=90=D7=A8=20=D7=92=D7=9C=D7=95=D7=99=20=D7=91=D7=A6=D7=93=20?= =?UTF-8?q?=D7=94=D7=9E=D7=A4=D7=A8=D7=A9?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit בטור חושן משפט ספריא מקשרת את הטור למפרשים (בית יוסף, ב"ח, פרישה, דרישה, דרכי משה) ברמת הסעיף, למשל Beit Yosef, Choshen Mishpat 157:1, ולא ברמת הקטע. ספריא מסמנת צד כזה ב-ANCHOR_NOT_SEGMENT, ולכן הקישור הוסתר בצד המפרש: כ-12 אלף קישורים, והמפרש לא הראה את הטור כלל. קישור COMMENTARY שצד המפרש שלו מוסתר רק מסיבה זו נשאר עכשיו גלוי. הקישור כבר נפתר לשורה הראשונה של הסעיף. כל סיבה אחרת, או צירוף שלה עם ANCHOR_NOT_SEGMENT, ממשיכה להסתיר, וכך גם הפניות שאינן פירוש. הבדיקה של הכיוון אחרי היפוך הקישור עברה ל-OTHER_TOO_COARSE, שעדיין מוסתר. --- .../sefariasqlite/SefariaLinksImporter.kt | 9 ++++++- .../SefariaSuppressedSideTest.kt | 24 ++++++++++++++++++- 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/generator/sefariasqlite/src/jvmMain/kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SefariaLinksImporter.kt b/generator/sefariasqlite/src/jvmMain/kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SefariaLinksImporter.kt index 5a209c3d..df819c3a 100644 --- a/generator/sefariasqlite/src/jvmMain/kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SefariaLinksImporter.kt +++ b/generator/sefariasqlite/src/jvmMain/kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SefariaLinksImporter.kt @@ -631,7 +631,7 @@ internal class SefariaLinksImporter( val srcSideMask = if (wasSwapped) exportedMask2 else exportedMask1 val tgtSideMask = if (wasSwapped) exportedMask1 else exportedMask2 queueSuppression(linkId, side = 0, mask = srcSideMask) - queueSuppression(linkId, side = 1, mask = tgtSideMask) + queueSuppression(linkId, side = 1, mask = commentarySideMask(storedType, tgtSideMask)) } // Ranged sides: record the range end + per-line coverage. @@ -1236,6 +1236,13 @@ internal fun computeBaseProvenance(storedSrcBook: Long, storedTgtMeta: BookMeta? /** The reasons that make a ranged side stop covering its unit's lines. */ internal const val WHOLE_UNIT_REASONS = SuppressionReason.WHOLE_PEREK or SuppressionReason.WHOLE_PARASHA +/** + * The commentary side of a COMMENTARY link stays visible when Sefaria hid it only for citing a + * whole section (Tur Choshen Mishpat → Beit Yosef 157:1): the link resolves to the section's first line. + */ +internal fun commentarySideMask(storedType: ConnectionType, mask: Int): Int = + if (storedType == ConnectionType.COMMENTARY && mask == SuppressionReason.ANCHOR_NOT_SEGMENT) 0 else mask + /** * A required `Suppression Mask 1/2` cell from a new-format export. Zero must be * explicit: a blank/missing/unparsable/unknown value fails closed. diff --git a/generator/sefariasqlite/src/jvmTest/kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SefariaSuppressedSideTest.kt b/generator/sefariasqlite/src/jvmTest/kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SefariaSuppressedSideTest.kt index 58420560..55c74160 100644 --- a/generator/sefariasqlite/src/jvmTest/kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SefariaSuppressedSideTest.kt +++ b/generator/sefariasqlite/src/jvmTest/kotlin/io/github/kdroidfilter/seforimlibrary/sefariasqlite/SefariaSuppressedSideTest.kt @@ -212,7 +212,7 @@ class SefariaSuppressedSideTest { row( "Migdal Oz 5:1", "Bava Batra 28a:1", - SuppressionReason.ANCHOR_NOT_SEGMENT, + SuppressionReason.OTHER_TOO_COARSE, 0, type = "commentary", ), @@ -221,6 +221,28 @@ class SefariaSuppressedSideTest { // The dependant→base CSV row is stored base→dependant. Citation 1's // verdict must therefore land on stored side 1, not side 0. assertEquals(1, imported.suppressed.size) + assertEquals( + listOf(1L, SuppressionReason.OTHER_TOO_COARSE.toLong()), + imported.suppressed[0].drop(1), + ) + } + + @Test + fun sectionLevelCommentaryCitationStaysVisibleOnTheCommentary() { + val imported = importWith( + HEADER_WITH_MASKS, + row("Migdal Oz 5:1", "Bava Batra 28a:1", SuppressionReason.ANCHOR_NOT_SEGMENT, 0, type = "commentary"), + ) + assertTrue(imported.suppressed.isEmpty(), "got ${imported.suppressed}") + } + + @Test + fun sectionLevelReferenceCitationStaysHidden() { + val imported = importWith( + HEADER_WITH_MASKS, + row("Bava Batra 28a:1", "Migdal Oz 5:1", 0, SuppressionReason.ANCHOR_NOT_SEGMENT), + ) + assertEquals(1, imported.suppressed.size) assertEquals( listOf(1L, SuppressionReason.ANCHOR_NOT_SEGMENT.toLong()), imported.suppressed[0].drop(1),