From 1955d3a9979fd7bff1ce0760181d8f08aed428f0 Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Tue, 10 Nov 2026 19:54:16 +0200 Subject: [PATCH 1/7] fix(csslib): retain Dart style clone metadata and detach font lists --- pkgs/csslib/CHANGELOG.md | 2 + pkgs/csslib/lib/src/tree.dart | 17 +++++---- pkgs/csslib/test/dart_style_clone_test.dart | 42 +++++++++++++++++++++ 3 files changed, 54 insertions(+), 7 deletions(-) create mode 100644 pkgs/csslib/test/dart_style_clone_test.dart diff --git a/pkgs/csslib/CHANGELOG.md b/pkgs/csslib/CHANGELOG.md index 48a162d374..e42f537e01 100644 --- a/pkgs/csslib/CHANGELOG.md +++ b/pkgs/csslib/CHANGELOG.md @@ -19,6 +19,8 @@ sharing mutable AST nodes between the original and its clone. - Preserve nested group terms, IE7-prefixed declaration flags, and variable usage state when cloning CSS expression/declaration nodes. +- Preserve Dart style priorities when cloning and detach mutable font-family + lists from cloned font expressions. - Fix `Rgba.fromArgbValue`, `Rgba.argbValue` and `Hsla.color`, preserve alpha for grayscale colors in `Hsla.fromRgba`, and keep the exact 8-bit alpha in `Color.rgba`, `Color.hsla` and `Hsla.fromArgbValue` instead of rounding it to diff --git a/pkgs/csslib/lib/src/tree.dart b/pkgs/csslib/lib/src/tree.dart index b11e95eed3..a0d192828f 100644 --- a/pkgs/csslib/lib/src/tree.dart +++ b/pkgs/csslib/lib/src/tree.dart @@ -1620,11 +1620,11 @@ class FontExpression extends DartStyleExpression { @override FontExpression clone() => FontExpression(span, size: font.size, - family: font.family, + family: font.family?.toList(), weight: font.weight, style: font.style, variant: font.variant, - lineHeight: font.lineHeight); + lineHeight: font.lineHeight)..priority = priority; @override dynamic visit(VisitorBase visitor) => visitor.visitFontExpression(this); @@ -1683,7 +1683,8 @@ class MarginExpression extends BoxExpression { @override MarginExpression clone() => MarginExpression(span, - top: box!.top, right: box!.right, bottom: box!.bottom, left: box!.left); + top: box!.top, right: box!.right, bottom: box!.bottom, left: box!.left) + ..priority = priority; @override dynamic visit(VisitorBase visitor) => visitor.visitMarginExpression(this); @@ -1719,7 +1720,8 @@ class BorderExpression extends BoxExpression { @override BorderExpression clone() => BorderExpression(span, - top: box!.top, right: box!.right, bottom: box!.bottom, left: box!.left); + top: box!.top, right: box!.right, bottom: box!.bottom, left: box!.left) + ..priority = priority; @override dynamic visit(VisitorBase visitor) => visitor.visitBorderExpression(this); @@ -1741,7 +1743,7 @@ class HeightExpression extends DartStyleExpression { } @override - HeightExpression clone() => HeightExpression(span, height); + HeightExpression clone() => HeightExpression(span, height)..priority = priority; @override dynamic visit(VisitorBase visitor) => visitor.visitHeightExpression(this); } @@ -1762,7 +1764,7 @@ class WidthExpression extends DartStyleExpression { } @override - WidthExpression clone() => WidthExpression(span, width); + WidthExpression clone() => WidthExpression(span, width)..priority = priority; @override dynamic visit(VisitorBase visitor) => visitor.visitWidthExpression(this); } @@ -1799,7 +1801,8 @@ class PaddingExpression extends BoxExpression { @override PaddingExpression clone() => PaddingExpression(span, - top: box!.top, right: box!.right, bottom: box!.bottom, left: box!.left); + top: box!.top, right: box!.right, bottom: box!.bottom, left: box!.left) + ..priority = priority; @override dynamic visit(VisitorBase visitor) => visitor.visitPaddingExpression(this); } diff --git a/pkgs/csslib/test/dart_style_clone_test.dart b/pkgs/csslib/test/dart_style_clone_test.dart new file mode 100644 index 0000000000..e86df64ab7 --- /dev/null +++ b/pkgs/csslib/test/dart_style_clone_test.dart @@ -0,0 +1,42 @@ +// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file +// for details. All rights reserved. Use of this source code is governed by a +// BSD-style license that can be found in the LICENSE file. + +import 'package:csslib/visitor.dart'; +import 'package:source_span/source_span.dart'; +import 'package:test/test.dart'; + +void main() { + test('font clones own their family list and retain priority', () { + final span = SourceFile.fromString('font').span(0, 4); + final names = ['Frank Ruhl', 'serif']; + final style = FontExpression(span, family: names)..priority = 37; + final clone = style.clone(); + + names[0] = 'different font'; + names.add('fallback'); + expect(clone.font.family, ['Frank Ruhl', 'serif']); + expect(clone.priority, 37); + + clone.font.family!.add('separate'); + expect(style.font.family, ['different font', 'serif', 'fallback']); + }); + + test('all Dart style subclasses retain priority when cloned', () { + final span = SourceFile.fromString('margin').span(0, 6); + final styles = [ + MarginExpression(span, left: 1), + BorderExpression(span, right: 2), + PaddingExpression(span, top: 3), + HeightExpression(span, 4), + WidthExpression(span, 5), + ]; + for (final style in styles) { + style.priority = 42; + final copy = style.clone() as DartStyleExpression; + expect(copy.priority, 42, reason: style.runtimeType.toString()); + copy.priority = 7; + expect(style.priority, 42); + } + }); +} From d2a9f8a677af2c669ba4047db675c7b31c8f9221 Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Tue, 10 Nov 2026 20:04:44 +0200 Subject: [PATCH 2/7] style(csslib): use formatter-stable clone bodies for Dart style metadata --- pkgs/csslib/lib/src/tree.dart | 62 +++++++++++++++++++++++++++-------- 1 file changed, 49 insertions(+), 13 deletions(-) diff --git a/pkgs/csslib/lib/src/tree.dart b/pkgs/csslib/lib/src/tree.dart index a0d192828f..ebb7d9f5ed 100644 --- a/pkgs/csslib/lib/src/tree.dart +++ b/pkgs/csslib/lib/src/tree.dart @@ -1618,13 +1618,18 @@ class FontExpression extends DartStyleExpression { super(DartStyleExpression.fontStyle, span); @override - FontExpression clone() => FontExpression(span, + FontExpression clone() { + final result = FontExpression( + span, size: font.size, family: font.family?.toList(), weight: font.weight, style: font.style, variant: font.variant, - lineHeight: font.lineHeight)..priority = priority; + lineHeight: font.lineHeight, + ); + return result..priority = priority; + } @override dynamic visit(VisitorBase visitor) => visitor.visitFontExpression(this); @@ -1682,9 +1687,17 @@ class MarginExpression extends BoxExpression { : super(x._styleType, span, BoxEdge.merge(x.box, y.box)); @override - MarginExpression clone() => MarginExpression(span, - top: box!.top, right: box!.right, bottom: box!.bottom, left: box!.left) - ..priority = priority; + MarginExpression clone() { + final edge = box!; + final result = MarginExpression( + span, + top: edge.top, + right: edge.right, + bottom: edge.bottom, + left: edge.left, + ); + return result..priority = priority; + } @override dynamic visit(VisitorBase visitor) => visitor.visitMarginExpression(this); @@ -1719,9 +1732,17 @@ class BorderExpression extends BoxExpression { DartStyleExpression.borderStyle, span, BoxEdge.merge(x.box, y.box)); @override - BorderExpression clone() => BorderExpression(span, - top: box!.top, right: box!.right, bottom: box!.bottom, left: box!.left) - ..priority = priority; + BorderExpression clone() { + final edge = box!; + final result = BorderExpression( + span, + top: edge.top, + right: edge.right, + bottom: edge.bottom, + left: edge.left, + ); + return result..priority = priority; + } @override dynamic visit(VisitorBase visitor) => visitor.visitBorderExpression(this); @@ -1743,7 +1764,11 @@ class HeightExpression extends DartStyleExpression { } @override - HeightExpression clone() => HeightExpression(span, height)..priority = priority; + HeightExpression clone() { + final result = HeightExpression(span, height); + return result..priority = priority; + } + @override dynamic visit(VisitorBase visitor) => visitor.visitHeightExpression(this); } @@ -1764,7 +1789,10 @@ class WidthExpression extends DartStyleExpression { } @override - WidthExpression clone() => WidthExpression(span, width)..priority = priority; + WidthExpression clone() { + final result = WidthExpression(span, width); + return result..priority = priority; + } @override dynamic visit(VisitorBase visitor) => visitor.visitWidthExpression(this); } @@ -1800,9 +1828,17 @@ class PaddingExpression extends BoxExpression { BoxEdge.merge(x.box, y.box)); @override - PaddingExpression clone() => PaddingExpression(span, - top: box!.top, right: box!.right, bottom: box!.bottom, left: box!.left) - ..priority = priority; + PaddingExpression clone() { + final edge = box!; + final result = PaddingExpression( + span, + top: edge.top, + right: edge.right, + bottom: edge.bottom, + left: edge.left, + ); + return result..priority = priority; + } @override dynamic visit(VisitorBase visitor) => visitor.visitPaddingExpression(this); } From 21984b6022f2471fde4491575120f2a351ebeb03 Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Tue, 10 Nov 2026 20:32:26 +0200 Subject: [PATCH 3/7] style(csslib): apply final Dart formatter layout to style clones --- pkgs/csslib/lib/src/tree.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/csslib/lib/src/tree.dart b/pkgs/csslib/lib/src/tree.dart index ebb7d9f5ed..057cb3f7af 100644 --- a/pkgs/csslib/lib/src/tree.dart +++ b/pkgs/csslib/lib/src/tree.dart @@ -1793,6 +1793,7 @@ class WidthExpression extends DartStyleExpression { final result = WidthExpression(span, width); return result..priority = priority; } + @override dynamic visit(VisitorBase visitor) => visitor.visitWidthExpression(this); } @@ -1839,6 +1840,7 @@ class PaddingExpression extends BoxExpression { ); return result..priority = priority; } + @override dynamic visit(VisitorBase visitor) => visitor.visitPaddingExpression(this); } From ca27e154bd54a410c0e500a5d56ea97052132b88 Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Tue, 10 Nov 2026 20:35:03 +0200 Subject: [PATCH 4/7] fix(csslib): clone declaration style instead of sharing mutable AST --- pkgs/csslib/lib/src/tree.dart | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/pkgs/csslib/lib/src/tree.dart b/pkgs/csslib/lib/src/tree.dart index 057cb3f7af..3c143f7c68 100644 --- a/pkgs/csslib/lib/src/tree.dart +++ b/pkgs/csslib/lib/src/tree.dart @@ -1053,9 +1053,17 @@ class Declaration extends TreeNode { SourceSpan get span => super.span!; @override - Declaration clone() => - Declaration(_property?.clone(), expression?.clone(), dartStyle, span, - important: important, ie7: isIE7); + Declaration clone() { + final style = dartStyle?.clone() as DartStyleExpression?; + return Declaration( + _property?.clone(), + expression?.clone(), + style, + span, + important: important, + ie7: isIE7, + ); + } @override dynamic visit(VisitorBase visitor) => visitor.visitDeclaration(this); From 54b568da87820da504448ab6460788af60609d78 Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Tue, 10 Nov 2026 20:35:22 +0200 Subject: [PATCH 5/7] test(csslib): verify declaration style deep clone and priority --- pkgs/csslib/test/dart_style_clone_test.dart | 27 +++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/pkgs/csslib/test/dart_style_clone_test.dart b/pkgs/csslib/test/dart_style_clone_test.dart index e86df64ab7..f6c50816ef 100644 --- a/pkgs/csslib/test/dart_style_clone_test.dart +++ b/pkgs/csslib/test/dart_style_clone_test.dart @@ -22,6 +22,33 @@ void main() { expect(style.font.family, ['different font', 'serif', 'fallback']); }); + test('declaration clones own the style payload and keep priority', () { + final span = SourceFile.fromString('font-size').span(0, 9); + final families = ['Alef']; + final original = Declaration( + Identifier('font-family', span), + null, + FontExpression(span, family: families)..priority = 31, + span, + important: true, + ie7: true, + ); + final copy = original.clone(); + final originalStyle = original.dartStyle! as FontExpression; + final copiedStyle = copy.dartStyle! as FontExpression; + + expect(copy.property, '*font-family'); + expect(copy.important, isTrue); + expect(identical(copiedStyle, originalStyle), isFalse); + expect(copiedStyle.priority, 31); + + copiedStyle.priority = 9; + copiedStyle.font.family!.add('serif'); + expect(originalStyle.priority, 31); + expect(originalStyle.font.family, ['Alef']); + expect(families, ['Alef']); + }); + test('all Dart style subclasses retain priority when cloned', () { final span = SourceFile.fromString('margin').span(0, 6); final styles = [ From 90fb1a8c1f4a7a28cca2f07eab17ae6cbf9214ba Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Tue, 10 Nov 2026 20:45:11 +0200 Subject: [PATCH 6/7] docs(csslib): document complete clone and font serialization behavior --- pkgs/csslib/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/csslib/CHANGELOG.md b/pkgs/csslib/CHANGELOG.md index e42f537e01..e8ae2bf557 100644 --- a/pkgs/csslib/CHANGELOG.md +++ b/pkgs/csslib/CHANGELOG.md @@ -21,6 +21,8 @@ usage state when cloning CSS expression/declaration nodes. - Preserve Dart style priorities when cloning and detach mutable font-family lists from cloned font expressions. +- Deep-clone declaration style payloads and preserve Dart style priorities; + detach mutable font-family lists in cloned font expressions. - Fix `Rgba.fromArgbValue`, `Rgba.argbValue` and `Hsla.color`, preserve alpha for grayscale colors in `Hsla.fromRgba`, and keep the exact 8-bit alpha in `Color.rgba`, `Color.hsla` and `Hsla.fromArgbValue` instead of rounding it to From ef1fd774a8e934d1560185ee10f0118f0356c7aa Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Tue, 10 Nov 2026 21:37:32 +0200 Subject: [PATCH 7/7] test(csslib): cover IE7 property hack surviving mixin includes --- pkgs/csslib/test/mixin_test.dart | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/pkgs/csslib/test/mixin_test.dart b/pkgs/csslib/test/mixin_test.dart index 684f914efc..5363ac4b71 100644 --- a/pkgs/csslib/test/mixin_test.dart +++ b/pkgs/csslib/test/mixin_test.dart @@ -209,6 +209,20 @@ div { }'''); } +void declMixinIE7Hack() { + compileAndValidate(r''' +@mixin legacy-color { + *color: red; +} +div { + @include legacy-color; +} +''', r''' +div { + *color: #f00; +}'''); +} + void declMixinTwoIncludes() { compileAndValidate(r''' @mixin div-border { @@ -624,6 +638,7 @@ void main() { group('Declaration mixin', () { test('simple', declSimpleMixin); + test('keeps IE7 property hack', declMixinIE7Hack); test('with two @includes', declMixinTwoIncludes); test('with includes', declMixinNestedIncludes); test('with deeper nesting', declMixinDeeperNestedIncludes);