General Questions

[johannesschobel]

Dear @OzanKurt ,

i am considering to switch my current repository implementation from L5-Repo ( https://github.com/andersao/l5-repository/ ) and stumbled upon this package here. Before switching, however, i need to get some more information, so here are a bunch of general questions

Here are some general questions:

• Is this package "actively" maintained and used?
• Are you planning to implement these features?
• Will you update the package to the latest Laravel 5.7 (and ongoing) version?
• What is the most significant benefit from your package compared to L5-repository?
• Are you planning to add tests for the Repository? Currently the entire package is not tested?!
• From the first glimpse this package looks quite nice. However, i am missing some core features known from L5-Repository, like :
  • ordering by attributes
  • filtering (e.g., only show specific fields)
  • including relationships (i know there is a EagerLoad criterion!) using a with() function
• Would you accept PRs to enhance the functionality? (consider the above-mentioned features!)

Thanks for your time and all the best!

[OzanKurt]

Thank you for these questions.

Answers:

• I'm usually making some improvements monthly, so I wouldn't say that it's so "active".
• When I finish my tasks at my company, yes.
• As soon as possible.
• I build this package for my own needs, you're free to choose which one fits you.
• Tests should be added for sure but not in my priority list.
• Some improvements can be done but I would prefer to keep the package as simple as possible, I would never use l5-repository since I feel that its extra overkill. (I usually read a repo's code before I use it.)
• Yes, there are already some lovely contributors helping me out.

[johannesschobel]

Hey there..

thanks for your answers.. I have reviewed your code a bit and have a question regarding the AbstractRepository:
Why do you provide a dedicated findWhereFirst() and not a first() / get() / last() method that may be applied to different where() methods? Similar to the laravel default style? Are there any particular reasons for this?

All the best

[OzanKurt]

The find there also felt a bit redundant for me too. The package should provide a memorable API while not confusing the users with the defaults of Laravel. AbstractRepository should be revamped.

[johannesschobel]

actually, i dont really mind the find($id) method at all; i think it is a handy shortcut to get a specific entity..

[OzanKurt]

The package you're referring to has many methods in their default repository class, I might not offer that many since I won't be following their approach where they edit the query fluently.

[OzanKurt]

It has been a long time, but I managed to make some nice changes to the project. I am planning to release them soon.