Skip to content

[Feedback]: #12

@Smashslice

Description

@Smashslice

Outcome 1

1.02- Break complex functions into manageable modules and functions

Outcome 1 Result

3-Mastery

Outcome 1 Feedback

There are good  uses of abstraction in both the points/views.py and in events/signals.py. Overall, there is no unnecessary code re-use I can see, things that should be functions are and the structure is clean and easy to understand at a glance.

Outcome 2

2.05- Define or modify API endpoints for data retrieval and manipulation

Outcome 2 Result

2-Near Mastery

Outcome 2 Feedback

There is a single API endpoint, and it was implemented correctly. However, there is a lot of data in the app and I would've liked to see more than one endpoint here.

Outcome 3

3.02- Modify RESTful APIs to add/update functionality

Outcome 3 Result

0-No Evidence

Outcome 3 Feedback

Unless I blatantly overlooked something, which isn't impossible, there is no RESTFUL API modification in the app. I would expect some evidence in either signals, models or views at some point in the app if it existed, but there is no evidence of that. 

Outcome 4

8.01- Visualize data using a chart or graph

Outcome 4 Result

0-No Evidence

Outcome 4 Feedback

There are no graphs used in the project.

Outcome 5

8.02- Elucidate data by customizing elements of a data visualization

Outcome 5 Result

0-No Evidence

Outcome 5 Feedback

There are no graphs used in the project.

Outcome 6

8.03- Integrate dynamic data visualizations into an application

Outcome 6 Result

0-No Evidence

Outcome 6 Feedback

There are no graphs used in the project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions