[Feedback]: Module 5 review

[Smashslice]

Outcome 1

4.06- Incorporate JavaScript into templates to create interactive web pages

Outcome 1 Result

0-No Evidence

Outcome 1 Feedback

The only javascript is directly out of the book and was not implemented in any way relevant to the actual app itself.

Outcome 2

6.04- Implement callbacks and event listeners in applications

Outcome 2 Result

0-No Evidence

Outcome 2 Feedback

There are no callbacks or event listeners present outside of the commented out bookmarklet implementation from the book.

Outcome 3

7.03- Employ PEP 8 style guidelines for readable code

Outcome 3 Result

1-Below Mastery

Outcome 3 Feedback

While there are some comments, they are mostly formatting, denoting what a section of code is dedicated to. While this is useful, on its own it's not enough to actually help navigate reading the code. Commenting on how certain pieces of logic work, e.x. "link = reverse_lazy('speedrun:game_list')" would be helpful. To figure out what this was doing, I had to go read the url util documentation and then determine the reason for using lazy vs normal reverse. A short comment explaining the goal and how this implementation achieved it would have been helpful. When you make that decision, the idea is fresh in your head. Putting it into a comment allows other people to avoid going back through the design and implementation decisions when reading your code. Also, committed cert and RSA private key to public repo.