[Feedback]: Module 7 Review

[Smashslice]

Outcome 1

1.02- Break complex functions into manageable modules and functions

Outcome 1 Result

3-Mastery

Outcome 1 Feedback

The abstraction into functions and manageable modules is done well throughout the app. There isn't any unnecessary redundant code and things are generally separated out in a logical and meaningful way.

Outcome 2

2.01- Implement access control for class members

Outcome 2 Result

3-Mastery

Outcome 2 Feedback

In views.py, has login required views that make sense, like creating a category and submitting a run.

Outcome 3

5.06- Utilize sessions/cookies to facilitate transmittal and storage of data

Outcome 3 Result

2-Near Mastery

Outcome 3 Feedback

Utilize sessions/cookies to facilitate transmittal and storage of data

The logic behind the session for storing the game is good, my one concern is the lack of a max age on the session. Django's default age for session storage is 2 weeks, and it seems unlikely we need to keep that in session memory for that long. Also one small gripe that didn't effect the grade but does affect code readability, I initially thought that 'submitted_run.game' was going to be an entire model, which wouldn't have serialized properly. I had to go check the model and realized it was the game's title/name, variable names generally should be very clear in what they contain.

Outcome 4

4.03- Follow standard conventions to develop an intuitive user interface

Outcome 4 Result

3-Mastery

Outcome 4 Feedback

The templates and css are coherent and laid out in a way that seems intuitive. 

Outcome 5

4.05- Configure and maintain URLs/Endpoints to ensure functional navigation and retrieval

Outcome 5 Result

3-Mastery

Outcome 5 Feedback

All the urls are wired up properly and appear functional.

Outcome 6

5.01- Utilize Object Relational Mapping (ORM) for data retrieval

Outcome 6 Result

3-Mastery

Outcome 6 Feedback

Multiple successful uses of ORM data retrieval throughout the site.