fix: address code review issues

- Import models in Alembic env.py so autogenerate detects tables
- Make ApiResponse.json/jsonList nullable for 204 No Content responses
- Add reaction_type path param to remove_reaction endpoint

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Eoic

client/lib/services/api_client.dart

@@ -108,7 +108,9 @@ class ApiResponse {
 
   bool get isSuccess => statusCode >= 200 && statusCode < 300;
 
-  Map<String, dynamic> get json => jsonDecode(body) as Map<String, dynamic>;
+  Map<String, dynamic>? get json =>
+      body.isNotEmpty ? jsonDecode(body) as Map<String, dynamic> : null;
 
-  List<dynamic> get jsonList => jsonDecode(body) as List<dynamic>;
+  List<dynamic>? get jsonList =>
+      body.isNotEmpty ? jsonDecode(body) as List<dynamic> : null;
 }

server/alembic/env.py

@@ -1,10 +1,11 @@
 import asyncio
 from logging.config import fileConfig
 
-from alembic import context
 from sqlalchemy import pool
 from sqlalchemy.ext.asyncio import async_engine_from_config
 
+import papyrus.models  # noqa: F401 — register models with Base.metadata
+from alembic import context
 from papyrus.config import get_settings
 from papyrus.core.database import Base
 

server/src/papyrus/api/routes/reviews.py

@@ -77,7 +77,7 @@ async def react_to_review(
     return Response(status_code=status.HTTP_204_NO_CONTENT)
 
 
-@router.delete("/{review_id}/react", status_code=status.HTTP_204_NO_CONTENT)
-async def remove_reaction(user_id: CurrentUserId, review_id: UUID) -> Response:
-    """Remove a reaction from a review."""
+@router.delete("/{review_id}/react/{reaction_type}", status_code=status.HTTP_204_NO_CONTENT)
+async def remove_reaction(user_id: CurrentUserId, review_id: UUID, reaction_type: str) -> Response:
+    """Remove a specific reaction from a review."""
     return Response(status_code=status.HTTP_204_NO_CONTENT)

server/tests/test_reviews.py

@@ -58,7 +58,7 @@ def test_react_to_review(client: TestClient, auth_headers: dict[str, str]):
 
 def test_remove_reaction(client: TestClient, auth_headers: dict[str, str]):
     review_id = str(uuid4())
-    response = client.delete(f"/v1/reviews/{review_id}/react", headers=auth_headers)
+    response = client.delete(f"/v1/reviews/{review_id}/react/like", headers=auth_headers)
     assert response.status_code == 204