From ef20e57b92c52af3ba34f62f789ff0181868057b Mon Sep 17 00:00:00 2001 From: d-montgomery Date: Tue, 11 Aug 2026 09:42:24 -0600 Subject: [PATCH 1/7] Test changes to an rst and Utility/*.py file --- Docs/sphinx/Utility.rst | 2 ++ Source/Utility/PMF/cantera_pmf_generator.py | 3 +++ 2 files changed, 5 insertions(+) diff --git a/Docs/sphinx/Utility.rst b/Docs/sphinx/Utility.rst index cf3023507..06a00820d 100644 --- a/Docs/sphinx/Utility.rst +++ b/Docs/sphinx/Utility.rst @@ -6,6 +6,8 @@ Utility ******* +Test changes + In addition to routines for evaluating chemical reactions, transport properties, and equation of state functions, PelePhysics includes other shared utilities that are utilized by both PeleC and PeleLM(eX). These utilities include support for: * Premixed Flame (``PMF``) initialization from precomputed 1D flame profiles diff --git a/Source/Utility/PMF/cantera_pmf_generator.py b/Source/Utility/PMF/cantera_pmf_generator.py index 83e5b89ac..06d9d7ffc 100644 --- a/Source/Utility/PMF/cantera_pmf_generator.py +++ b/Source/Utility/PMF/cantera_pmf_generator.py @@ -16,6 +16,9 @@ import yaml from cantera import Solution, FreeFlame +# Test changes +zz = 1 + ################################################################# # Parse arguments ################################################################# From 188271f31318722af12ea5bf8f45f671796f4823 Mon Sep 17 00:00:00 2001 From: d-montgomery Date: Tue, 11 Aug 2026 10:07:58 -0600 Subject: [PATCH 2/7] Add Detect-Changes --- .github/workflows/ci.yml | 34 +++++++++++++++------ .github/workflows/downstream.yml | 29 +++++++++++++----- Docs/sphinx/Utility.rst | 2 -- Source/Utility/PMF/cantera_pmf_generator.py | 3 -- 4 files changed, 45 insertions(+), 23 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 00b8c161f..79fe2cd26 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,23 +4,34 @@ on: workflow_dispatch: push: branches: [development] - paths-ignore: - - '**.rst' - - 'Docs/**' - - 'Source/Utility/**/*.py' pull_request: branches: [development] - paths-ignore: - - '**.rst' - - 'Docs/**' - - 'Source/Utility/**/*.py' concurrency: group: ${{github.ref}}-${{github.head_ref}}-ci cancel-in-progress: true jobs: + Detect-Changes: + runs-on: ubuntu-latest + outputs: + has-source-changes: ${{ steps.changes.outputs.src }} + steps: + - uses: actions/checkout@v6 + with: + fetch-depth: 0 + - uses: dorny/paths-filter@v2 + id: changes + with: + filters: | + src: + - '**' + - '!Docs/**' + - '!Source/Utility/**/*.py' + Formatting: + needs: Detect-Changes + if: needs.Detect-Changes.outputs.has-source-changes == 'true' runs-on: ubuntu-24.04 steps: - name: Clone @@ -34,7 +45,7 @@ jobs: clangFormatVersion: 20 Codespell: - needs: Formatting + needs: Detect-Changes runs-on: ubuntu-24.04 steps: - name: Clone @@ -54,6 +65,8 @@ jobs: run: codespell CEPTR: + needs: Detect-Changes + if: needs.Detect-Changes.outputs.has-source-changes == 'true' runs-on: ubuntu-24.04 strategy: fail-fast: false @@ -88,7 +101,8 @@ jobs: run: poetry run convert -f ${{github.workspace}}/Mechanisms/LiDryer/mechanism.yaml Transport-EOS-Reactions: - needs: Formatting + needs: Detect-Changes + if: needs.Detect-Changes.outputs.has-source-changes == 'true' runs-on: ubuntu-24.04 strategy: matrix: diff --git a/.github/workflows/downstream.yml b/.github/workflows/downstream.yml index 8bc7390da..51f009f4b 100644 --- a/.github/workflows/downstream.yml +++ b/.github/workflows/downstream.yml @@ -4,23 +4,34 @@ on: workflow_dispatch: push: branches: [development] - paths-ignore: - - '**.rst' - - 'Docs/**' - - 'Source/Utility/**/*.py' pull_request: branches: [development] - paths-ignore: - - '**.rst' - - 'Docs/**' - - 'Source/Utility/**/*.py' concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.ref }} cancel-in-progress: true jobs: + Detect-Changes: + runs-on: ubuntu-latest + outputs: + has-source-changes: ${{ steps.changes.outputs.src }} + steps: + - uses: actions/checkout@v6 + with: + fetch-depth: 0 + - uses: dorny/paths-filter@v2 + id: changes + with: + filters: | + src: + - '**' + - '!Docs/**' + - '!Source/Utility/**/*.py' + PeleLMeX-FlameSheet: + needs: Detect-Changes + if: needs.Detect-Changes.outputs.has-source-changes == 'true' name: PeleLMeX GNU MPI Run [FlameSheet] runs-on: ubuntu-latest env: @@ -67,6 +78,8 @@ jobs: mpirun -n 2 ./PeleLMeX2d.gnu.MPI.drm19.ex input.2d-regt amr.max_step=2 amr.plot_int=-1 amr.check_int=-1 amrex.abort_on_unused_inputs=1 amr.n_cell=32 64 PeleC-PMF: + needs: Detect-Changes + if: needs.Detect-Changes.outputs.has-source-changes == 'true' name: PeleC GNU MPI Run [PMF] runs-on: ubuntu-latest env: diff --git a/Docs/sphinx/Utility.rst b/Docs/sphinx/Utility.rst index 06a00820d..cf3023507 100644 --- a/Docs/sphinx/Utility.rst +++ b/Docs/sphinx/Utility.rst @@ -6,8 +6,6 @@ Utility ******* -Test changes - In addition to routines for evaluating chemical reactions, transport properties, and equation of state functions, PelePhysics includes other shared utilities that are utilized by both PeleC and PeleLM(eX). These utilities include support for: * Premixed Flame (``PMF``) initialization from precomputed 1D flame profiles diff --git a/Source/Utility/PMF/cantera_pmf_generator.py b/Source/Utility/PMF/cantera_pmf_generator.py index 06d9d7ffc..83e5b89ac 100644 --- a/Source/Utility/PMF/cantera_pmf_generator.py +++ b/Source/Utility/PMF/cantera_pmf_generator.py @@ -16,9 +16,6 @@ import yaml from cantera import Solution, FreeFlame -# Test changes -zz = 1 - ################################################################# # Parse arguments ################################################################# From 7b2062a31b1233c3dfcc3e48572bfb04da95284a Mon Sep 17 00:00:00 2001 From: d-montgomery Date: Tue, 11 Aug 2026 10:19:44 -0600 Subject: [PATCH 3/7] Add more files to ignore --- .github/workflows/ci.yml | 4 ++++ .github/workflows/downstream.yml | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 79fe2cd26..ef792d3a1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,6 +28,10 @@ jobs: - '**' - '!Docs/**' - '!Source/Utility/**/*.py' + - '!README.md' + - '!CONTRIBUTING.md' + - '!.codespell*' + - '!.gitignore' Formatting: needs: Detect-Changes diff --git a/.github/workflows/downstream.yml b/.github/workflows/downstream.yml index 51f009f4b..e2d1458d3 100644 --- a/.github/workflows/downstream.yml +++ b/.github/workflows/downstream.yml @@ -28,6 +28,10 @@ jobs: - '**' - '!Docs/**' - '!Source/Utility/**/*.py' + - '!README.md' + - '!CONTRIBUTING.md' + - '!.codespell*' + - '!.gitignore' PeleLMeX-FlameSheet: needs: Detect-Changes From 2f00691b7c7d1edb63e01b05dd99697c05d01c49 Mon Sep 17 00:00:00 2001 From: d-montgomery Date: Tue, 11 Aug 2026 10:21:59 -0600 Subject: [PATCH 4/7] Test detection --- Docs/sphinx/Utility.rst | 2 ++ Source/Utility/PMF/cantera_pmf_generator.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Docs/sphinx/Utility.rst b/Docs/sphinx/Utility.rst index cf3023507..28ec8cc73 100644 --- a/Docs/sphinx/Utility.rst +++ b/Docs/sphinx/Utility.rst @@ -6,6 +6,8 @@ Utility ******* +Test detection + In addition to routines for evaluating chemical reactions, transport properties, and equation of state functions, PelePhysics includes other shared utilities that are utilized by both PeleC and PeleLM(eX). These utilities include support for: * Premixed Flame (``PMF``) initialization from precomputed 1D flame profiles diff --git a/Source/Utility/PMF/cantera_pmf_generator.py b/Source/Utility/PMF/cantera_pmf_generator.py index 83e5b89ac..83967e608 100644 --- a/Source/Utility/PMF/cantera_pmf_generator.py +++ b/Source/Utility/PMF/cantera_pmf_generator.py @@ -16,6 +16,8 @@ import yaml from cantera import Solution, FreeFlame +# Test detection + ################################################################# # Parse arguments ################################################################# From f75ea7558848c469f9bc7feeebdfa554515f052c Mon Sep 17 00:00:00 2001 From: d-montgomery Date: Tue, 11 Aug 2026 10:25:49 -0600 Subject: [PATCH 5/7] Revert rst and .py -- detection worked --- Docs/sphinx/Utility.rst | 2 -- Source/Utility/PMF/cantera_pmf_generator.py | 2 -- 2 files changed, 4 deletions(-) diff --git a/Docs/sphinx/Utility.rst b/Docs/sphinx/Utility.rst index 28ec8cc73..cf3023507 100644 --- a/Docs/sphinx/Utility.rst +++ b/Docs/sphinx/Utility.rst @@ -6,8 +6,6 @@ Utility ******* -Test detection - In addition to routines for evaluating chemical reactions, transport properties, and equation of state functions, PelePhysics includes other shared utilities that are utilized by both PeleC and PeleLM(eX). These utilities include support for: * Premixed Flame (``PMF``) initialization from precomputed 1D flame profiles diff --git a/Source/Utility/PMF/cantera_pmf_generator.py b/Source/Utility/PMF/cantera_pmf_generator.py index 83967e608..83e5b89ac 100644 --- a/Source/Utility/PMF/cantera_pmf_generator.py +++ b/Source/Utility/PMF/cantera_pmf_generator.py @@ -16,8 +16,6 @@ import yaml from cantera import Solution, FreeFlame -# Test detection - ################################################################# # Parse arguments ################################################################# From 4b1b4c2da4bf0e6e8563c9a93154e5cbd6eb65e7 Mon Sep 17 00:00:00 2001 From: Dave Montgomery Date: Tue, 18 Aug 2026 11:20:15 -0600 Subject: [PATCH 6/7] Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- .github/workflows/ci.yml | 3 ++- .github/workflows/downstream.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ef792d3a1..c91a4489d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,6 +26,7 @@ jobs: filters: | src: - '**' + - '!**/*.rst' - '!Docs/**' - '!Source/Utility/**/*.py' - '!README.md' @@ -35,7 +36,7 @@ jobs: Formatting: needs: Detect-Changes - if: needs.Detect-Changes.outputs.has-source-changes == 'true' +if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' runs-on: ubuntu-24.04 steps: - name: Clone diff --git a/.github/workflows/downstream.yml b/.github/workflows/downstream.yml index e2d1458d3..5182fce86 100644 --- a/.github/workflows/downstream.yml +++ b/.github/workflows/downstream.yml @@ -26,6 +26,7 @@ jobs: filters: | src: - '**' + - '!**/*.rst' - '!Docs/**' - '!Source/Utility/**/*.py' - '!README.md' @@ -35,7 +36,7 @@ jobs: PeleLMeX-FlameSheet: needs: Detect-Changes - if: needs.Detect-Changes.outputs.has-source-changes == 'true' +if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' name: PeleLMeX GNU MPI Run [FlameSheet] runs-on: ubuntu-latest env: From cdf27b8b7d8b19f0e451307014592d5ffe59370c Mon Sep 17 00:00:00 2001 From: d-montgomery Date: Tue, 18 Aug 2026 11:28:21 -0600 Subject: [PATCH 7/7] Fix remaining needs.Detect-Changes not caught by Copilot --- .github/workflows/ci.yml | 6 +++--- .github/workflows/downstream.yml | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c91a4489d..f4bb266b5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,7 +36,7 @@ jobs: Formatting: needs: Detect-Changes -if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' + if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' runs-on: ubuntu-24.04 steps: - name: Clone @@ -71,7 +71,7 @@ if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' CEPTR: needs: Detect-Changes - if: needs.Detect-Changes.outputs.has-source-changes == 'true' + if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' runs-on: ubuntu-24.04 strategy: fail-fast: false @@ -107,7 +107,7 @@ if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' Transport-EOS-Reactions: needs: Detect-Changes - if: needs.Detect-Changes.outputs.has-source-changes == 'true' + if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' runs-on: ubuntu-24.04 strategy: matrix: diff --git a/.github/workflows/downstream.yml b/.github/workflows/downstream.yml index 5182fce86..4fe9fb862 100644 --- a/.github/workflows/downstream.yml +++ b/.github/workflows/downstream.yml @@ -36,7 +36,7 @@ jobs: PeleLMeX-FlameSheet: needs: Detect-Changes -if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' + if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' name: PeleLMeX GNU MPI Run [FlameSheet] runs-on: ubuntu-latest env: @@ -84,7 +84,7 @@ if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' PeleC-PMF: needs: Detect-Changes - if: needs.Detect-Changes.outputs.has-source-changes == 'true' + if: needs['Detect-Changes'].outputs['has-source-changes'] == 'true' name: PeleC GNU MPI Run [PMF] runs-on: ubuntu-latest env: