From 88aa23276762ae606d83091c2a7e12d68d2d3652 Mon Sep 17 00:00:00 2001 From: PerfectPan <24316656+PerfectPan@users.noreply.github.com> Date: Tue, 17 Nov 2026 17:24:33 +0800 Subject: [PATCH] fix(build): restore the web build dependency of @rivus/estela vp pack copies apps/web/dist into the package, so the web app has to be in the @rivus/estela... build filter that the smoke suite and the Publish check run. Knip removed the devDependency as unused, which left 0.4.0's Publish check without a web build. Knip now keeps it, with the reason. Co-Authored-By: Claude Opus 5.5 --- apps/cli/package.json | 1 + knip.ts | 6 +++++- pnpm-lock.yaml | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/apps/cli/package.json b/apps/cli/package.json index 50b13e3..2137506 100644 --- a/apps/cli/package.json +++ b/apps/cli/package.json @@ -49,6 +49,7 @@ "@rivus/estela-runtime-node": "workspace:*", "@rivus/estela-schema": "workspace:*", "@rivus/estela-server": "workspace:*", + "@rivus/estela-web": "workspace:*", "@types/node": "catalog:", "typescript": "catalog:", "vite-plus": "catalog:", diff --git a/knip.ts b/knip.ts index bba41c6..bf79756 100644 --- a/knip.ts +++ b/knip.ts @@ -22,7 +22,11 @@ const config = { 'apps/cli': { // The dual-mode launcher: `./cli.mjs` only exists next to it in dist after // `vp pack` (see bin.mjs), so the file is excluded from import analysis. - ignore: ['bin.mjs'] + ignore: ['bin.mjs'], + // Build order, not an import: `vp pack` copies apps/web/dist into the + // package, so `pnpm --filter '@rivus/estela...' run build` (the smoke + // suite and the Publish check) must build the web app first. + ignoreDependencies: ['@rivus/estela-web'] }, 'apps/e2e': { entry: ['src/demo/*.ts!'] diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 8f45392..a9f67ca 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -239,6 +239,9 @@ importers: '@rivus/estela-server': specifier: workspace:* version: link:../../packages/server + '@rivus/estela-web': + specifier: workspace:* + version: link:../web '@types/node': specifier: 'catalog:' version: 24.19.2