Skip to content

Standardize on an icon system #899

Description

@slifty

Our recent Ionicons migration exposed that we are pretty inconsistent with our iconography.

Current State: Three Icon Systems

  ┌────────────────┬───────────────────────────┬───────────────────────────────────────────────────┐                                                                                                                       
  │     System     │        Usage Count        │                  Implementation                   │                                                                                                                       
  ├────────────────┼───────────────────────────┼───────────────────────────────────────────────────┤                                                                                                                       
  │ Material Icons │ 52 occurrences (32 files) │ <i class="material-icons">name</i> via Google CDN │                                                                                                                       
  ├────────────────┼───────────────────────────┼───────────────────────────────────────────────────┤                                                                                                                       
  │ FontAwesome    │ 27 occurrences (21 files) │ <fa-icon [icon]="..."> via npm packages           │                                                                                                                       
  ├────────────────┼───────────────────────────┼───────────────────────────────────────────────────┤                                                                                                                       
  │ Ionicons       │ 14 occurrences            │ <ion-icon name="..."> as web components           │                                                                                                                       
  └────────────────┴───────────────────────────┴───────────────────────────────────────────────────┘            

Key Inconsistencies Found

Folder Icon (most notable):

  • Material Icons: file-list-item.component.html:28,39, file-list-controls.component.html:40, global-search-bar.component.html:43,87,100, folder-picker.component.html:32
  • Ionicons: thumbnail.component.html:10, global-search-results.component.html:57,63, nav.component.html:60

Close/Dismiss:

  • Material Icons: 13+ dialogs use close
  • FontAwesome: 2 announcements use <fa-icon [icon]="['fas', 'window-close']">

Search:

  • Ionicons: left-menu.component.html, global-search-bar.component.html
  • FontAwesome: gallery.component.html

Navigation Arrows:

  • Ionicons: caret-back, caret-forward
  • FontAwesome: chevron-left, chevron-down

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions