Skip to content

Commit 0e2425e

Browse files
authored
Merge pull request #382 from PlanExeOrg/fix/database-worker-env-naming
fix: use PLANEXE_POSTGRES_* env vars in database_worker
2 parents 153559a + 4aece1c commit 0e2425e

4 files changed

Lines changed: 28 additions & 22 deletions

File tree

PlanExe.code-workspace

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,12 @@
3737
},
3838
{
3939
"path": "mcp_local"
40+
},
41+
{
42+
"path": "database_worker"
43+
},
44+
{
45+
"path": "llm_config"
4046
}
4147
],
4248
"settings": {

database_worker/railway.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,18 @@ This service provides database backup (via `pg_dump`) and is called by `frontend
77
## Service variables example
88

99
```
10-
PGHOST="${{shared.PLANEXE_POSTGRES_HOST}}"
11-
PGPORT="5432"
12-
PGDATABASE="planexe"
13-
PGUSER="planexe"
14-
PGPASSWORD="${{shared.PLANEXE_POSTGRES_PASSWORD}}"
10+
PLANEXE_POSTGRES_HOST="${{shared.PLANEXE_POSTGRES_HOST}}"
11+
PLANEXE_POSTGRES_PORT="5432"
12+
PLANEXE_POSTGRES_DB="planexe"
13+
PLANEXE_POSTGRES_USER="planexe"
14+
PLANEXE_POSTGRES_PASSWORD="${{shared.PLANEXE_POSTGRES_PASSWORD}}"
1515
PLANEXE_DATABASE_WORKER_API_KEY="${{shared.PLANEXE_DATABASE_WORKER_API_KEY}}"
1616
```
1717

1818
## Required Environment Variables
1919

20-
- `PGHOST` — Postgres host. On Railway, use the internal hostname (e.g. `postgres.railway.internal`). The Docker Compose default `database_postgres` does not resolve on Railway.
21-
- `PGPASSWORD` — Postgres password.
20+
- `PLANEXE_POSTGRES_HOST` — Postgres host. On Railway, use the internal hostname (e.g. `postgres.railway.internal`). The Docker Compose default `database_postgres` does not resolve on Railway.
21+
- `PLANEXE_POSTGRES_PASSWORD` — Postgres password.
2222

2323
## Optional Environment Variables
2424

database_worker/server.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@
99
logging.basicConfig(level=logging.INFO, format="%(asctime)s %(levelname)s %(message)s")
1010
logger = logging.getLogger(__name__)
1111

12-
PGHOST = os.environ.get("PGHOST", "database_postgres")
13-
PGPORT = os.environ.get("PGPORT", "5432")
14-
PGDATABASE = os.environ.get("PGDATABASE", "planexe")
15-
PGUSER = os.environ.get("PGUSER", "planexe")
16-
PGPASSWORD = os.environ.get("PGPASSWORD", "planexe")
12+
POSTGRES_HOST = os.environ.get("PLANEXE_POSTGRES_HOST", "database_postgres")
13+
POSTGRES_PORT = os.environ.get("PLANEXE_POSTGRES_PORT", "5432")
14+
POSTGRES_DB = os.environ.get("PLANEXE_POSTGRES_DB", "planexe")
15+
POSTGRES_USER = os.environ.get("PLANEXE_POSTGRES_USER", "planexe")
16+
POSTGRES_PASSWORD = os.environ.get("PLANEXE_POSTGRES_PASSWORD", "planexe")
1717
API_KEY = os.environ.get("PLANEXE_DATABASE_WORKER_API_KEY", "")
1818
# Railway injects PORT; fall back to PLANEXE_DATABASE_WORKER_PORT for Docker Compose.
1919
PORT = int(os.environ.get("PORT") or os.environ.get("PLANEXE_DATABASE_WORKER_PORT", "8002"))
@@ -66,15 +66,15 @@ def do_GET(self):
6666
logger.info("Starting database backup: %s (%s)", filename, "zstd" if _HAS_ZSTD else "gzip")
6767

6868
env = os.environ.copy()
69-
env["PGPASSWORD"] = PGPASSWORD
69+
env["PGPASSWORD"] = POSTGRES_PASSWORD # pg_dump reads PGPASSWORD from env
7070

7171
proc = subprocess.Popen(
7272
[
7373
"pg_dump",
74-
"-h", PGHOST,
75-
"-p", PGPORT,
76-
"-U", PGUSER,
77-
"-d", PGDATABASE,
74+
"-h", POSTGRES_HOST,
75+
"-p", POSTGRES_PORT,
76+
"-U", POSTGRES_USER,
77+
"-d", POSTGRES_DB,
7878
"--no-owner",
7979
"--no-privileges",
8080
"-Z", compress_flag,

docker-compose.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,11 +224,11 @@ services:
224224
database_postgres:
225225
condition: service_healthy
226226
environment:
227-
PGHOST: database_postgres
228-
PGPORT: "5432"
229-
PGDATABASE: ${PLANEXE_POSTGRES_DB:-planexe}
230-
PGUSER: ${PLANEXE_POSTGRES_USER:-planexe}
231-
PGPASSWORD: ${PLANEXE_POSTGRES_PASSWORD:-planexe}
227+
PLANEXE_POSTGRES_HOST: database_postgres
228+
PLANEXE_POSTGRES_PORT: "5432"
229+
PLANEXE_POSTGRES_DB: ${PLANEXE_POSTGRES_DB:-planexe}
230+
PLANEXE_POSTGRES_USER: ${PLANEXE_POSTGRES_USER:-planexe}
231+
PLANEXE_POSTGRES_PASSWORD: ${PLANEXE_POSTGRES_PASSWORD:-planexe}
232232
PLANEXE_DATABASE_WORKER_API_KEY: ${PLANEXE_DATABASE_WORKER_API_KEY:-}
233233
restart: unless-stopped
234234

0 commit comments

Comments
 (0)