Skip to content

[BUG] SearchEngine::new Ignores use_reranker Parameter #209

@xyz080125

Description

@xyz080125

Project

vgrep

Description

In search.rs line 23-34, the SearchEngine::new function takes _use_reranker as a parameter but explicitly ignores it with an underscore prefix and a comment. This is misleading since the parameter exists but does nothing.

Error Message

Debug Logs

System Information

OS: Any
Rust Version: 1.75+

Screenshots

No response

Steps to Reproduce

  1. Configure vgrep with use_reranker=true
  2. Perform searches
  3. Observe that reranking doesn't occur

Expected Behavior

Either implement reranking or remove the parameter/document its non-functional status clearly

Actual Behavior

Parameter is silently ignored, misleading users who configure it

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingvalidValid issuevgrep

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions