From 92cdba7f889a2ce394cdbf4c0c06a67009ccf1c5 Mon Sep 17 00:00:00 2001 From: Juan Andres Quiroz Date: Wed, 13 May 2020 12:04:24 -0500 Subject: [PATCH 1/2] reto resuelto y ensayado con tests --- .gitignore | 3 +++ challenge.py | 22 ++++++++++++++++++---- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index b6e4761..e971917 100644 --- a/.gitignore +++ b/.gitignore @@ -127,3 +127,6 @@ dmypy.json # Pyre type checker .pyre/ + +# .vscode folder +.vscode/ diff --git a/challenge.py b/challenge.py index 2653d7e..bf4b1e1 100644 --- a/challenge.py +++ b/challenge.py @@ -2,8 +2,10 @@ def make_division_by(n): """This closure returns a function that returns the division of an x number by n """ - # You have to code here! - pass + def division_n(x): + return x/n + + return division_n def run(): @@ -21,8 +23,20 @@ def run(): import unittest class ClosureSuite(unittest.TestCase): + def setUp(self): + self.funcs={3:make_division_by(3), + 5:make_division_by(5), + 18:make_division_by(18)} + def test_closure_make_division_by(self): - # Make the closure test here - pass + self.assertEqual(5, self.funcs[3](15)) + + self.assertEqual(8, self.funcs[5](40)) + + self.assertEqual(9, self.funcs[18](162)) + + def tearDown(self): + del(self.funcs) + #unittest.main() run() From e234ac173b4f5d1c4ef3910d985ed2bd74fe1b3d Mon Sep 17 00:00:00 2001 From: Juan Andres Quiroz Date: Sat, 16 May 2020 06:50:52 -0500 Subject: [PATCH 2/2] Se mejora legilibilidad del codigo --- challenge.py | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/challenge.py b/challenge.py index bf4b1e1..b96217e 100644 --- a/challenge.py +++ b/challenge.py @@ -23,20 +23,14 @@ def run(): import unittest class ClosureSuite(unittest.TestCase): - def setUp(self): - self.funcs={3:make_division_by(3), - 5:make_division_by(5), - 18:make_division_by(18)} - def test_closure_make_division_by(self): - self.assertEqual(5, self.funcs[3](15)) - self.assertEqual(8, self.funcs[5](40)) + self.assertEqual(5, make_division_by(3)(15)) + + self.assertEqual(8, make_division_by(5)(40)) + + self.assertEqual(9, make_division_by(18)(162)) - self.assertEqual(9, self.funcs[18](162)) - - def tearDown(self): - del(self.funcs) #unittest.main() run()