From 1327d9eaa9a6bd439ed4a5b4ce762463320f8304 Mon Sep 17 00:00:00 2001
From: Dimitris Gkanatsios <digkanat@microsoft.com>
Date: Mon, 10 Aug 2026 16:23:24 -0700
Subject: [PATCH] Drop stale cppsdk/include references left by the vendored SDK
 removal

#203 deleted cpp/cppsdk/include, but two build files still added it to
their include path:

- cpp/CMakeLists.txt passed cppsdk/include to target_include_directories
- GSDK_CPP_UnitTests.vcxproj listed $(SolutionDir)cppsdk\include in the
  Debug and Release configurations

Neither CMake nor MSBuild errors on a nonexistent -I path, so CI stayed
green and nothing was broken. They are simply dead now.

Also removes a duplicate $(SolutionDir)cppsdk from the same two
AdditionalIncludeDirectories lines, which predates #203. All four unit
test configurations now list the same three include paths.

Reported by @amccalib in review on #203.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6defd46f-b276-4683-bedd-6ba3aecdaa7f
---
 cpp/CMakeLists.txt                       | 3 +--
 cpp/unittests/GSDK_CPP_UnitTests.vcxproj | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index 5803c1d0..fddfc794 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -27,8 +27,7 @@ add_library(GSDK_CPP
 )
 
 target_include_directories(GSDK_CPP PRIVATE
-    cppsdk
-    cppsdk/include)
+    cppsdk)
 
 set_target_properties(GSDK_CPP PROPERTIES CXX_STANDARD 14)
 
diff --git a/cpp/unittests/GSDK_CPP_UnitTests.vcxproj b/cpp/unittests/GSDK_CPP_UnitTests.vcxproj
index ac656eca..daa5a3f9 100644
--- a/cpp/unittests/GSDK_CPP_UnitTests.vcxproj
+++ b/cpp/unittests/GSDK_CPP_UnitTests.vcxproj
@@ -96,7 +96,7 @@
       <Optimization>MaxSpeed</Optimization>
       <FunctionLevelLinking>true</FunctionLevelLinking>
       <IntrinsicFunctions>true</IntrinsicFunctions>
-      <AdditionalIncludeDirectories>$(SolutionDir)dependencies\libcurl-vc15-x64-release-dll-ssl-dll-ipv6-sspi\include;$(SolutionDir)cppsdk;$(VCInstallDir)UnitTest\include;$(SolutionDir)cppsdk;$(SolutionDir)cppsdk\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
+      <AdditionalIncludeDirectories>$(SolutionDir)dependencies\libcurl-vc15-x64-release-dll-ssl-dll-ipv6-sspi\include;$(SolutionDir)cppsdk;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
       <PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <UseFullPaths>true</UseFullPaths>
       <RuntimeLibrary>MultiThreaded</RuntimeLibrary>
@@ -116,7 +116,7 @@
       <Optimization>MaxSpeed</Optimization>
       <FunctionLevelLinking>true</FunctionLevelLinking>
       <IntrinsicFunctions>true</IntrinsicFunctions>
-      <AdditionalIncludeDirectories>$(SolutionDir)dependencies\libcurl-vc15-x64-release-dll-ssl-dll-ipv6-sspi\include;$(SolutionDir)cppsdk;$(VCInstallDir)UnitTest\include;$(SolutionDir)cppsdk;$(SolutionDir)cppsdk\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
+      <AdditionalIncludeDirectories>$(SolutionDir)dependencies\libcurl-vc15-x64-release-dll-ssl-dll-ipv6-sspi\include;$(SolutionDir)cppsdk;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
       <PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <UseFullPaths>true</UseFullPaths>
       <RuntimeLibrary>MultiThreadedDLL</RuntimeLibrary>