Skip to content

Bug with “Don't remind me again” checkbox in the MapModificationWarningDialog component #742

@Palbolsky

Description

@Palbolsky

Describe the bug

Issue: https://discord.com/channels/143824995867557888/1490033292064591943

There is an issue with the MapModificationWarningDialog modal. Even if you check “Don't remind me again”, the dialog box still reappears.

The bug is caused by an issue with the checkbox's ref, which is no longer propagated correctly following a change made 10 months ago.

So the bug isn't caused by MapModificationWarningDialog but by the Checkbox component.

Steps to reproduce

Steps to reproduce the behavior:

  1. In SaveProjectButton, comment the condition in the handleSave function
  2. In the Studio console, go to Application > Local Storage. If the props neverRemindMeMapModification exists, change the value for false.
  3. Make any changes in Studio and save.
  4. The MapModificationWarningDialog appears. Check “Don't remind me again”.
  5. In the Studio console, go to Application > Local Storage and check neverRemindMeMapModification. If false = bug, if true = it's fixed.

Expected behavior

After checking the “Don't ask me again” box, the dialog box should no longer appear.

Which version of Pokémon Studio are you using?

2.9.2

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Type

    No fields configured for Bug.

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions