fix: validate and diagnose recents writes

Generated-By: PostHog Code
Task-Id: f68869f0-4c94-4017-add1-ce18b6a323b3

Author: k11kirky

packages/core/src/recents/recentsService.test.ts

@@ -75,4 +75,20 @@ describe("RecentsService", () => {
       }),
     );
   });
+
+  it("does not rewrite a non-canvas row supplied as a canvas id", async () => {
+    const { service, getEntry, fetch } = serviceWith([]);
+    getEntry.mockResolvedValue({
+      id: "task-row",
+      path: "Tasks/task-row",
+      type: "task",
+      ref: "task-row",
+    } as never);
+
+    await expect(
+      service.record({ kind: "canvas", id: "task-row" }),
+    ).rejects.toThrow("Canvas not found");
+
+    expect(fetch).not.toHaveBeenCalled();
+  });
 });

packages/core/src/recents/recentsService.ts

@@ -54,7 +54,8 @@ export class RecentsService {
 
   private async ensureCanvasReference(id: string): Promise<void> {
     const entry = await this.fs.getEntry<RecentFsEntry>(id, "canvas");
-    if (!entry) throw new Error("Canvas not found");
+    if (!entry || entry.type !== "dashboard")
+      throw new Error("Canvas not found");
     if (entry.ref === id) return;
     const response = await this.fs.fetch(`${encodeURIComponent(id)}/`, {
       method: "PATCH",

packages/ui/src/features/recents/useRecents.ts

@@ -1,9 +1,12 @@
 import type { RecentEngagementInput } from "@posthog/core/recents/schemas";
 import { useHostTRPC, useHostTRPCClient } from "@posthog/host-router/react";
 import { AUTH_SCOPED_QUERY_META } from "@posthog/ui/features/auth/useCurrentUser";
+import { logger } from "@posthog/ui/shell/logger";
 import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
 import { useCallback } from "react";
 
+const log = logger.scope("recents");
+
 export function useRecents() {
   const trpc = useHostTRPC();
   return useQuery(
@@ -25,6 +28,9 @@ export function useRecordRecentEngagement(): (
       client.recents.record.mutate(input),
     onSuccess: () =>
       queryClient.invalidateQueries(trpc.recents.list.pathFilter()),
+    onError: (error, input) => {
+      log.warn("Failed to record recent engagement", { error, input });
+    },
   });
   return useCallback((input: RecentEngagementInput) => mutate(input), [mutate]);
 }