From 9f5caf731052ac4cfb2e3c5c2077b0411fe6f24c Mon Sep 17 00:00:00 2001 From: Peter Kirkham Date: Thu, 16 Jul 2026 11:40:17 +0100 Subject: [PATCH 1/2] test(shared): cover explicit HTTPS port Generated-By: PostHog Code Task-Id: 864ed341-adf3-40b7-b37c-baef45c4f05d --- packages/shared/src/url.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/shared/src/url.test.ts b/packages/shared/src/url.test.ts index 5fb495d609..5e06ba0e28 100644 --- a/packages/shared/src/url.test.ts +++ b/packages/shared/src/url.test.ts @@ -6,6 +6,7 @@ describe("isSafeExternalUrl", () => { "https://github.com/PostHog/code/pull/42", "http://example.com", "https://example.com/path?q=1#frag", + "https://example.com:443/path", "HTTPS://EXAMPLE.COM", "mailto:hi@posthog.com", ])("allows %s", (url) => { From 322e343a5368dec5f028d56bc92bf2ea9f16ff04 Mon Sep 17 00:00:00 2001 From: Peter Kirkham Date: Thu, 16 Jul 2026 12:10:50 +0100 Subject: [PATCH 2/2] test(shared): clarify explicit port coverage Generated-By: PostHog Code Task-Id: 864ed341-adf3-40b7-b37c-baef45c4f05d --- packages/shared/src/url.test.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/shared/src/url.test.ts b/packages/shared/src/url.test.ts index 5e06ba0e28..c10779d610 100644 --- a/packages/shared/src/url.test.ts +++ b/packages/shared/src/url.test.ts @@ -6,13 +6,16 @@ describe("isSafeExternalUrl", () => { "https://github.com/PostHog/code/pull/42", "http://example.com", "https://example.com/path?q=1#frag", - "https://example.com:443/path", "HTTPS://EXAMPLE.COM", "mailto:hi@posthog.com", ])("allows %s", (url) => { expect(isSafeExternalUrl(url)).toBe(true); }); + it("allows HTTPS URLs with an explicit port", () => { + expect(isSafeExternalUrl("https://example.com:8443/path")).toBe(true); + }); + it.each([ "javascript:alert(1)", "file:///etc/passwd",