From 30f05803c156f582531a9a90dd30b8d9eeac41d7 Mon Sep 17 00:00:00 2001 From: matks Date: Tue, 18 Feb 2020 14:36:49 +0100 Subject: [PATCH 1/4] Add core weekly 7 of 2020 --- .../2020-02-18-coreweekly-week-07-2020.md | 137 ++++++++++++++++++ 1 file changed, 137 insertions(+) create mode 100644 news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md diff --git a/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md b/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md new file mode 100644 index 00000000000..ce9707876b7 --- /dev/null +++ b/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md @@ -0,0 +1,137 @@ +--- +layout: post +title: "PrestaShop Core Weekly - Week 7 of 2020" +subtitle: "An inside look at the PrestaShop codebase" +date: 2020-02-18 +authors: [ PrestaShop ] +image: /assets/images/2017/04/core_weekly_banner.jpg +icon: icon-calendar +tags: + - core-weekly +--- + +This edition of the Core Weekly report highlights changes in PrestaShop's core codebase from Monday 10th to Sunday 16th of February 2020. + +![Core Weekly banner](/assets/images/2018/12/banner-core-weekly.jpg) + +## General messages + +Dear developers, + +Last week our Product Team had a wonderful surprise: they received a notification telling them someone opened a [Pull Request on the Specifications repository](https://github.com/PrestaShop/prestashop-specs/pull/86) ! They were delighted to see the community willing to collaborate on us on this project. + +Obviously we would be very happy to see more of this kind of contributions, so if you feel like doing some Product Owner/Manager work, [feel free to join in](https://github.com/PrestaShop/prestashop-specs/) ! + + +## A quick update about PrestaShop's GitHub issues and pull requests: + +- [11 new issues](https://github.com/search?q=org%3APrestaShop+is%3Apublic++-repo%3Aprestashop%2Fprestashop.github.io++is%3Aissue+created%3A2020-02-10..2020-02-16) have been created in the project repositories; +- [58 issues have been closed](https://github.com/search?q=org%3APrestaShop+is%3Apublic++-repo%3Aprestashop%2Fprestashop.github.io++is%3Aissue+closed%3A2020-02-10..2020-02-16), including [11 fixed issues](https://github.com/search?q=org%3APrestaShop+is%3Apublic++-repo%3Aprestashop%2Fprestashop.github.io++is%3Aissue+label%3Afixed+closed%3A2020-02-10..2020-02-16) on the core; +- [56 pull requests have been opened](https://github.com/search?q=org%3APrestaShop+is%3Apublic++-repo%3Aprestashop%2Fprestashop.github.io++is%3Apr+created%3A2020-02-10..2020-02-16) in the project repositories; +- [45 pull requests have been closed](https://github.com/search?q=org%3APrestaShop+is%3Apublic++-repo%3Aprestashop%2Fprestashop.github.io++is%3Apr+closed%3A2020-02-10..2020-02-16), including [33 merged pull requests](https://github.com/search?q=org%3APrestaShop+is%3Apublic++-repo%3Aprestashop%2Fprestashop.github.io++is%3Apr+merged%3A2020-02-10..2020-02-16). + + +## Code changes in the 'develop' branch + + +### Core +* [#17616](https://github.com/PrestaShop/PrestaShop/pull/17616): Remove useless assets, by [@PierreRambaud](https://github.com/PierreRambaud) +* [#17589](https://github.com/PrestaShop/PrestaShop/pull/17589): Update Configuration::get phpdoc. Thank you [@zalexki](https://github.com/zalexki) +* [#17088](https://github.com/PrestaShop/PrestaShop/pull/17088): Allow override of Product::cleanPositions() function. Thank you [@jtraulle](https://github.com/jtraulle) + + +### Back office +* [#17459](https://github.com/PrestaShop/PrestaShop/pull/17459): Adjust zindex header to avoid it behind over the menu on mobile, by [@NeOMakinG](https://github.com/NeOMakinG) +* [#17450](https://github.com/PrestaShop/PrestaShop/pull/17450): Don't loose group access on object model category save(). Thank you [@jf-viguier](https://github.com/jf-viguier) +* [#16543](https://github.com/PrestaShop/PrestaShop/pull/16543): Fixing menu animation to be opened properly, by [@NeOMakinG](https://github.com/NeOMakinG) +* [#16287](https://github.com/PrestaShop/PrestaShop/pull/16287): Don't duplicate currencies in DB when creating a formerly deleted one , by [@matthieu-rolland](https://github.com/matthieu-rolland) + + +### Front office +* [#17569](https://github.com/PrestaShop/PrestaShop/pull/17569): On virtual product, the delivery time shouldn't display. Thank you [@PeeyushAgrawalWebkul](https://github.com/PeeyushAgrawalWebkul) +* [#17522](https://github.com/PrestaShop/PrestaShop/pull/17522): FIX - Disabled products are visible with wrong token or no token at all. Thank you [@PululuK](https://github.com/PululuK) +* [#17477](https://github.com/PrestaShop/PrestaShop/pull/17477): Register new 1.7.8 hooks into XML and SQL files, by [@matks](https://github.com/matks) +* [#17243](https://github.com/PrestaShop/PrestaShop/pull/17243): Permit submit form button to be outside of a form with a form attribute, by [@NeOMakinG](https://github.com/NeOMakinG) + + +### Tests +* [#17556](https://github.com/PrestaShop/PrestaShop/pull/17556): Improve Travis config file to avoid green builds if File Syntax fails, by [@matks](https://github.com/matks) + + +### Merge +* [#17581](https://github.com/PrestaShop/PrestaShop/pull/17581): Merge 1.7.7.x into develop - 10/02/2020, by [@matks](https://github.com/matks) + + +## Code changes in the '1.7.7.x' branch (for v1.7.7.0) + + +### Core +* [#17579](https://github.com/PrestaShop/PrestaShop/pull/17579): Update license headers 2020 , by [@PierreRambaud](https://github.com/PierreRambaud) +* [#17149](https://github.com/PrestaShop/PrestaShop/pull/17149): Cancel product, by [@matthieu-rolland](https://github.com/matthieu-rolland) + + +### Back office +* [#17649](https://github.com/PrestaShop/PrestaShop/pull/17649): Fix wrong address edit link in order detail, by [@atomiix](https://github.com/atomiix) +* [#17614](https://github.com/PrestaShop/PrestaShop/pull/17614): Missing assets generation, by [@PierreRambaud](https://github.com/PierreRambaud) +* [#17612](https://github.com/PrestaShop/PrestaShop/pull/17612): Fixed Empty Option in Smarty Form in Advanced Parameters > Performance, by [@Progi1984](https://github.com/Progi1984) +* [#17583](https://github.com/PrestaShop/PrestaShop/pull/17583): Migration 1.7.7.x Register all new hooks. Thank you [@tdavidsonas88](https://github.com/tdavidsonas88) + + +### Installer +* [#17642](https://github.com/PrestaShop/PrestaShop/pull/17642): Fix SQL request for order detail, by [@jolelievre](https://github.com/jolelievre) + + +### Tests +* [#17652](https://github.com/PrestaShop/PrestaShop/pull/17652): Functional tests - Fix monitoring test. Thank you [@nesrineabdmouleh](https://github.com/nesrineabdmouleh) +* [#17643](https://github.com/PrestaShop/PrestaShop/pull/17643): CS fix, by [@jolelievre](https://github.com/jolelievre) +* [#17624](https://github.com/PrestaShop/PrestaShop/pull/17624): Functional tests - Product settings enable/disable force update friendly url. Thank you [@nesrineabdmouleh](https://github.com/nesrineabdmouleh) +* [#17620](https://github.com/PrestaShop/PrestaShop/pull/17620): Functional tests - 02_orders/ Reduce legal free text length to 10 characters. Thank you [@nesrineabdmouleh](https://github.com/nesrineabdmouleh) +* [#17566](https://github.com/PrestaShop/PrestaShop/pull/17566): Functional tests - CRUD web service key. Thank you [@nesrineabdmouleh](https://github.com/nesrineabdmouleh) +* [#17555](https://github.com/PrestaShop/PrestaShop/pull/17555): Functional tests - Product settings max size short description. Thank you [@nesrineabdmouleh](https://github.com/nesrineabdmouleh) + + +## Code changes in the '1.7.6.x' branch (for v1.7.6.4) + + +### Core +* [#17433](https://github.com/PrestaShop/PrestaShop/pull/17433): Do not escape translations when using the legacy translator from the new one, by [@Progi1984](https://github.com/Progi1984) + + +### Front office +* [#17608](https://github.com/PrestaShop/PrestaShop/pull/17608): Email subject doesn't support html entities, by [@Progi1984](https://github.com/Progi1984) + + +## Code changes in modules, themes & tools + + +### TranslationTools Bundle +* [#73](https://github.com/PrestaShop/TranslationToolsBundle/pull/73): Bump symfony/var-exporter from 4.2.8 to 4.4.4. Thank you [@dependabot[bot]](https://github.com/apps/dependabot) + + +### Changes in developer documentation +* [#454](https://github.com/PrestaShop/docs/pull/454): Fix formatting .`tpl` -> `.tpl`. Thank you [@DrevanTonder](https://github.com/DrevanTonder) + + +### Customer Account Links module +* [#20](https://github.com/PrestaShop/ps_customeraccountlinks/pull/20): Fix call to undefined function. Thank you [@davidglezz](https://github.com/davidglezz) + + +### Reminder module +* [#4](https://github.com/PrestaShop/ps_reminder/pull/4): BO: Fix url made for cron job. Thank you [@kim-nani](https://github.com/kim-nani) + + +
+ +Thank you to the contributors whose pull requests were merged since the last Core Weekly Report: [@nesrineabdmouleh](https://github.com/nesrineabdmouleh), [@atomiix](https://github.com/atomiix), [@jolelievre](https://github.com/jolelievre), [@arouiadib](https://github.com/arouiadib), [@dependabot[bot]](https://github.com/apps/dependabot), [@PierreRambaud](https://github.com/PierreRambaud), [@Progi1984](https://github.com/Progi1984), [@DrevanTonder](https://github.com/DrevanTonder), [@zalexki](https://github.com/zalexki), [@tdavidsonas88](https://github.com/tdavidsonas88), [@matks](https://github.com/matks), [@PeeyushAgrawalWebkul](https://github.com/PeeyushAgrawalWebkul), [@PululuK](https://github.com/PululuK), [@NeOMakinG](https://github.com/NeOMakinG), [@jf-viguier](https://github.com/jf-viguier), [@matthieu-rolland](https://github.com/matthieu-rolland), [@jtraulle](https://github.com/jtraulle), [@davidglezz](https://github.com/davidglezz), [@kim-nani](https://github.com/kim-nani)! + +Thank you to the contributors whose PRs haven't been merged yet! And of course, a big thank you to all those who contribute with issues and comments [on GitHub](https://github.com/PrestaShop/PrestaShop)! + +If you want to contribute to PrestaShop with code, please read these pages first: + + * [Contributing code to PrestaShop](https://devdocs.prestashop.com/1.7/contribute/contribution-guidelines/) + * [Coding standards](https://devdocs.prestashop.com/1.7/development/coding-standards/) + +...and if you do not know how to fix an issue but wish to report it, please read this: [How to use GitHub to report an issue](https://devdocs.prestashop.com/1.7/contribute/contribute-reporting-issues/). Thank you! + +Happy contributin' everyone! + From 3d8f8535921e5608d4f42d945784e60cb70675c9 Mon Sep 17 00:00:00 2001 From: Mathieu Ferment Date: Tue, 18 Feb 2020 14:51:05 +0100 Subject: [PATCH 2/4] Apply suggestions from code review Co-Authored-By: Pablo Borowicz --- .../_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md b/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md index ce9707876b7..db3d2d2f8c4 100644 --- a/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md +++ b/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md @@ -18,9 +18,9 @@ This edition of the Core Weekly report highlights changes in PrestaShop's core c Dear developers, -Last week our Product Team had a wonderful surprise: they received a notification telling them someone opened a [Pull Request on the Specifications repository](https://github.com/PrestaShop/prestashop-specs/pull/86) ! They were delighted to see the community willing to collaborate on us on this project. +Last week our Product Team had a wonderful surprise: they received a notification telling them someone opened a [Pull Request on the Specifications repository](https://github.com/PrestaShop/prestashop-specs/pull/86)! They were delighted to see the community willing to collaborate on us on this project. -Obviously we would be very happy to see more of this kind of contributions, so if you feel like doing some Product Owner/Manager work, [feel free to join in](https://github.com/PrestaShop/prestashop-specs/) ! +Obviously we would be very happy to see more of this kind of contributions, so if you feel like doing some Product Owner/Manager work, [feel free to join in](https://github.com/PrestaShop/prestashop-specs/)! ## A quick update about PrestaShop's GitHub issues and pull requests: @@ -134,4 +134,3 @@ If you want to contribute to PrestaShop with code, please read these pages first ...and if you do not know how to fix an issue but wish to report it, please read this: [How to use GitHub to report an issue](https://devdocs.prestashop.com/1.7/contribute/contribute-reporting-issues/). Thank you! Happy contributin' everyone! - From 9bbc53c6b4851391e3fa91c23a621e2605c25667 Mon Sep 17 00:00:00 2001 From: matks Date: Wed, 19 Feb 2020 10:31:55 +0100 Subject: [PATCH 3/4] Improve thanks for specs repo contribution --- news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md b/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md index ce9707876b7..58de10a4a15 100644 --- a/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md +++ b/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md @@ -18,9 +18,9 @@ This edition of the Core Weekly report highlights changes in PrestaShop's core c Dear developers, -Last week our Product Team had a wonderful surprise: they received a notification telling them someone opened a [Pull Request on the Specifications repository](https://github.com/PrestaShop/prestashop-specs/pull/86) ! They were delighted to see the community willing to collaborate on us on this project. +Last week our Product Team had a wonderful surprise: they received a notification telling them someone opened a [Pull Request on the Specifications repository](https://github.com/PrestaShop/prestashop-specs/pull/86)! This is the first community contribution since this repository dedicated to centralize all core and module functional specifications has been created. They were delighted to see the community willing to collaborate with us on this huge work. -Obviously we would be very happy to see more of this kind of contributions, so if you feel like doing some Product Owner/Manager work, [feel free to join in](https://github.com/PrestaShop/prestashop-specs/) ! +We offer our very big thanks to [@arouiadib](https://github.com/arouiadib) for his contribution. Obviously we would be very happy to welcome more contributions, so if you feel like doing some Product Owner/Manager work, [feel free to join in](https://github.com/PrestaShop/prestashop-specs/) ! ## A quick update about PrestaShop's GitHub issues and pull requests: From 60e4289e8b619e4102ab5d7e96e223ba6260eb96 Mon Sep 17 00:00:00 2001 From: Mathieu Ferment Date: Thu, 20 Feb 2020 13:14:36 +0100 Subject: [PATCH 4/4] Update core weekly 7 date --- news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md b/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md index f9861a38edd..7025d2f023e 100644 --- a/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md +++ b/news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md @@ -2,7 +2,7 @@ layout: post title: "PrestaShop Core Weekly - Week 7 of 2020" subtitle: "An inside look at the PrestaShop codebase" -date: 2020-02-18 +date: 2020-02-20 authors: [ PrestaShop ] image: /assets/images/2017/04/core_weekly_banner.jpg icon: icon-calendar