Product import does not take into account Watermark module settings.

[k0lv]

Describe the bug
I have activated in Watermark module (v2.0.0) watermark only for two sizes [large_default (800 x 800) and medium_default (452 x 452)].
Issue: After Product import, I see watermark also on the [cart_default (125 x 125); home_default (250 x 250); small_default (98 x 98)]

Edit by Khouloud: steps to reproduce the issue

1. install PS1.7.6.2
2. install Watermark module v2.0.0
3. configure it:
   3.1. Watermark X align / Watermark Y align => Middle
   3.2 Choose image types for watermark protection => large_default / medium_default
   3.3 Go to the BO => Design => Image Settings => Regenerate thumbnails
4. Go to the Import page => import products
   Products_1.xlsx
   4.1 Delete all products before import
   4.2 Use product reference as a key

After Import, check the products in the FO => NOK
Workaround:
After Product Import use Design / Image Settings / REGENERATE THUMBNAILS

Screenshots
Pictures after Product import:

Pictures after Regeneration:

Additional information
PrestaShop version: 1.7.6.2
PHP version: 7.0.33

[khouloudbelguith]

Hi @k0lv,

I did not manage to reproduce the issue with PS1.7.6.2 & the watermark module v2.0.0.
I attached a screen record
https://drive.google.com/file/d/1SFEY7FKSgpb1jZTbmHYihr0T6Bkqpl_l/view
Thanks to check & feedback.

[k0lv]

Hi @k0lv,

I did not manage to reproduce the issue with PS1.7.6.2 & the watermark module v2.0.0.
I attached a screen record
https://drive.google.com/file/d/1SFEY7FKSgpb1jZTbmHYihr0T6Bkqpl_l/view
Thanks to check & feedback.

Hello, @khouloudbelguith . Can you please clean browser cache and also check what files on server are located in the Product img folder. I have taken my files from the server. Also what I have found, that if "Generate high resolution images" is set to YES, Product import does not generate "x2" files, so I believe, that Product Import Picture generation functionality is not the same, as used by the "REGENERATE THUMBNAILS".
P.S. I have just tried clean product load(to the empty database) one more time, and all image sizes received watermark... :(

[khouloudbelguith]

@k0lv,

Also what I have found, that if "Generate high resolution images" is set to YES, Product import does not generate "x2" files

This issue is fixed in the next version PS1.7.7.0, here's the PR: PrestaShop/PrestaShop#16097

Can you please clean browser cache and also check what files on server are located in the Product img folder

Tried again & it is OK
https://drive.google.com/file/d/1WlQE1_1yudNWE1wv0UzmahFNg94G6P5k/view

Images are restored in the Project_Folder/img/p/id_product/id_product-watermak.jpg

Thanks!

[k0lv]

I am starting to think, that maybe PHP version has an impact. What PHP version do you have?
I am currently in the process of migration from 1.6 to 1.7, when I will finish, I will upgrade PHP to the latest version and retest.

Additional proofs:

1. PS is clean, no products exist:
   
2. Watermark module is set up:
   
3. Folder on server do not have pictures:
   
4. Loading new products
   Products_1.xlsx
   
   
   
5. Products are imported:
   
6. Files are populated:
   
7. More files got watermark, that set up in the Module:
   
   1-cart_default.jpg.zip
   
8. Launching regeneration:
   
9. Files on server updated:
   
10. No watermark on unnecessary sizes:
    

[khouloudbelguith]

@k0lv, I'm using PHPv7.1.33.
PrestaShop is not compatible with PHP 7.3, in fact, PrestaShop 1.7.0 to 1.7.3 is compatible with PHP 7.1 and PrestaShop 1.7.4 & 1.7.5 & PS1.7.6 are compatible with PHP 7.2.
For more details, you can follow this link: http://build.prestashop.com/news/prestashop-1-7-is-moving-to-symfony-3-4-and-php-5-6/
Next Major release PS1.7.7 will be compatible with PHP7.3.

@k0lv, after a new fresh install
I followed these steps:

1. install PS1.7.6.2
2. install Watermark module v2.0.0
3. configure it:
   3.1. Watermark X align / Watermark Y align => Middle
   3.2 Choose image types for watermark protection => large_default / medium_default
   3.3 Go to the BO => Design => Image Settings => Regenerate thumbnails
4. Go to the Import page => import products
   Products_1.xlsx
   4.1 Delete all products before import
   4.2 Use product reference as a key

After Import, check the products in the FO => NOK

We need to Regenerate thumbnails again.
https://drive.google.com/file/d/1PwRFE6xNA8eozC3mE4glAWAHMZ30N9gm/view

PS: Watermark is compatible with minimum PS1.7.6.0: https://github.com/PrestaShop/watermark/blob/master/watermark.php#L73
I’ll add this to the debug roadmap so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!
Thanks!