Skip to content

[bug] Verify common-plugins.md plugin-update Phase 1.5 cascade claim (mid-plan tangential from #45) #66

@kiki830621

Description

@kiki830621

Problem

Source: surfaced during /idd-plan #45 tangential sweep (Step 2.5)

#45 Plan tier 的 D3 (Mixed-type handling) 採用「plugin-update is superset, cascades to mcp-deploy」rule,理由引用 che-claude-config/rules/common-plugins.md:

plugin-tools:plugin-update v1.11+ 是 dependency-aware orchestrator:
Phase 1.5 偵測依賴 → 掃 .mcp.json / wrapper / session-start hook
發現不同步 → AskUserQuestion 三選項:順便更新 / 只更新 shell / 中止
選「順便更新」→ 自動呼叫 /mcp-tools:mcp-deploy/cli-tools:cli-upgrade

但這是文件 claim,未 empirically 驗證:

  • plugin-update v1.11+ 是否真的有 Phase 1.5 detection
  • AskUserQuestion 三選項是否真的會 fire
  • 「順便更新」分支是否真的 invoke mcp-deploy
  • 對 mixed-type repo (e.g. che-zotero-mcp 同時是 plugin + MCP binary) 的實際 behavior 為何

若 claim 是 stale (e.g. cascade behavior 已被 refactor 移除 / Phase 1.5 從未實作),#45 D3 superset rule 就會錯 — 用戶選 chain plugin-update 結果 binary 沒 sync,出現「修了卻沒修」的 #45 issue 想根除的反 pattern。

Type

bug (verification gap with cascading correctness risk) OR docs (if doc accurate but reading misled)

Priority

P3 (depends on #45 implementation timing)

Proposed Investigation Steps

  1. Read psychquant-claude-plugins/plugins/plugin-tools/skills/plugin-update/SKILL.md Phase 1.5 source
  2. Verify Phase 1.5 detection logic exists + matches doc claim
  3. Empirically test on che-zotero-mcp (mixed plugin+MCP):
    • Modify a plugin file
    • Run /plugin-tools:plugin-update che-zotero-mcp
    • Observe: does Phase 1.5 fire? Does AskUserQuestion appear with cascade option? Does /mcp-tools:mcp-deploy actually invoke when chosen?
  4. Document findings:

Acceptance

Related

Source: surfaced during /idd-plan #45 tangential sweep (Step 2.5). Plan comment: #45 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions