fix: replace hardcoded localhost URLs with NEXT_PUBLIC_API_URL #24
Open
pericharlabindhumadhavi-data wants to merge 1 commit into
Open
Conversation
|
@pericharlabindhumadhavi-data is attempting to deploy a commit to the Pushkarini 's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
Problem
The login and signup pages were hardcoding the backend URL:
http://localhost:5000/api/auth/loginhttp://localhost:5000/api/auth/signupThis causes silent failures in any deployed environment because
localhost:5000only exists on the developer's machine. Meanwhile the upload page was already correctly usingprocess.env.NEXT_PUBLIC_API_URL— making the behavior inconsistent across the app.Fix
Replaced hardcoded URLs in both auth pages with the same environment-variable pattern used by the upload page:
This ensures:
Files Changed
src/app/auth/login/page.tsxsrc/app/auth/signup/page.tsxTesting
apiUrlvariable is present in both filesNEXT_PUBLIC_API_URLwill now correctly route auth requests