From 8c892025976f1c6a2acf3815d27b4620454b9260 Mon Sep 17 00:00:00 2001 From: sotashimozono Date: Wed, 9 Sep 2026 09:59:14 +0000 Subject: [PATCH] chore: drop the preview-base override, and the comment explaining why it was there MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comment said the reusable workflow defaults to `codes.sota-shimozono.com`, which does not resolve — correct, and it stayed correct here while every other caller of that workflow kept posting a dead link. QAtlasHub/.github#26 fixed the default instead: it now asks the Pages API where the site is, which for this repository answers `https://qatlashub.github.io/SweepRunner.jl/`. Both the override and its explanation go, because the condition the explanation describes no longer holds and a comment that outlives its condition is worse than none. Co-Authored-By: Claude Opus 5 --- .github/workflows/DocsPreview.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/DocsPreview.yml b/.github/workflows/DocsPreview.yml index e5ac40b..4a6dfa9 100644 --- a/.github/workflows/DocsPreview.yml +++ b/.github/workflows/DocsPreview.yml @@ -3,14 +3,8 @@ name: Docs Preview # Split out of Documentation.yml, which used to build the live site and post the PR preview # comment in one job. The reusable pair separates them because the deploy runs on `main` and the # preview runs on a pull request, and the two need different permissions. -# -# `preview-base` is set explicitly: the reusable defaults to `codes.sota-shimozono.com`, which -# does not resolve, whereas this repository's docs are served from GitHub Pages. The link the -# comment posts has to be one a reviewer can click. on: { pull_request: {} } jobs: preview: uses: QAtlasHub/.github/.github/workflows/docs-preview.yml@main - with: - preview-base: 'https://qatlashub.github.io' secrets: inherit