From 23c6120fdc9a9222643dff76753f80fceebb99eb Mon Sep 17 00:00:00 2001 From: Matt McKay Date: Tue, 25 Aug 2026 14:37:37 +1000 Subject: [PATCH] ci: re-pin fixtures to the merged byline demo (fixtures #2) The previous pin pointed at the fixtures #2 branch head, which was necessary while that PR was red: its self-check builds against the latest released theme, and `translators` did not exist until v0.22.0. It has shipped and the PR is merged, so point at the merge commit. Rewrites the comment to describe the two-step dance generally, since it will catch the next person adding a fixtures demo of a new theme option. Co-Authored-By: Claude Fable 5 --- .github/workflows/ci.yml | 19 ++++++++++++------- .github/workflows/update-snapshots.yml | 2 +- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 50c3223..9a1c434 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,13 +10,18 @@ on: # PRs. To bump the pin, update FIXTURES_SHA below. env: FIXTURES_REPO: QuantEcon/quantecon-book-theme-fixtures - # Includes the announcement-banner demo (merged in fixtures #1) and the - # author/translator byline demo (fixtures #2), so the preview/visual build - # exercises both. Points at the fixtures #2 branch head rather than a merge - # commit: that PR's own self-check builds against the latest *released* - # theme, which does not know the `translators` option yet, so it stays red - # until this ships. Re-pin to the merge commit once it does. - FIXTURES_SHA: ab9ba206d48870e86b822c74380546e42fcba299 + # Includes the announcement-banner demo (fixtures #1) and the author and + # translator byline demo (fixtures #2), so the preview/visual build + # exercises both. + # + # Adding a fixtures demo of a brand-new theme option is a two-step dance: + # the fixtures repo's own self-check installs the latest *released* theme + # and builds with --warningiserror, so it fails with "unsupported theme + # option" until that option ships. Pin this to the fixtures branch head to + # get the demo under test here (this repo installs the PR's own theme), then + # re-pin to the merge commit after the release. Options inherited from + # pydata_sphinx_theme, such as `announcement`, skip the dance entirely. + FIXTURES_SHA: 0048d104ed1afa587b824d130e5210dc969713c5 # Explicit least-privilege permissions: # contents: write — checkout + upload-artifact + nwtgck/actions-netlify diff --git a/.github/workflows/update-snapshots.yml b/.github/workflows/update-snapshots.yml index b055453..85345dc 100644 --- a/.github/workflows/update-snapshots.yml +++ b/.github/workflows/update-snapshots.yml @@ -11,7 +11,7 @@ on: # "Resolve fixtures pin" step. env: FIXTURES_REPO: QuantEcon/quantecon-book-theme-fixtures - FIXTURES_SHA: ab9ba206d48870e86b822c74380546e42fcba299 + FIXTURES_SHA: 0048d104ed1afa587b824d130e5210dc969713c5 jobs: # /update-new-snapshots — only creates MISSING snapshots (safe for adding new tests)