diff --git a/.github/sdk-release.json b/.github/sdk-release.json index 88d6be8..7aecc63 100644 --- a/.github/sdk-release.json +++ b/.github/sdk-release.json @@ -1,4 +1,4 @@ { - "engine_commit": "e630d1a33560d2a449747f00b4700f4770060793", + "engine_commit": "dcb5145dfeb3906830c0c6dc6b6d1f22ad1b4950", "attempt": 1 } diff --git a/README.md b/README.md index 3cc5da7..ce750c7 100644 --- a/README.md +++ b/README.md @@ -87,3 +87,8 @@ logs to troubleshoot a private build. Automation in this repository is AGPL-3.0-only. SDK components retain their own licences and required notices; this repository's licence does not relicense them. + +The portable core is published only as `portable/{Debug,Release}/WolEngine.Core.dll` +and its reference props. These DLLs use the same PE/debug-directory audit as the +backend. The allowlist grants no permission for core source, symbols, extra +assemblies or build output; the existing source and log exclusions still apply. diff --git a/release.py b/release.py index 8ba66de..7ea35dd 100644 --- a/release.py +++ b/release.py @@ -88,7 +88,8 @@ def check_sdk(cls, archive, commit, target): native_platform, arch, extension = cls.TARGETS[target] required = {"WolEngine.props", "GodotApi.props", "native/spatial.gdextension", f"native/bin/libspatial.{native_platform}.template_release.{arch}.{extension}", - "managed/Debug/WolEngine.dll", "managed/Release/WolEngine.dll"} + "managed/Debug/WolEngine.dll", "managed/Release/WolEngine.dll", + "portable/Debug/WolEngine.Core.dll", "portable/Release/WolEngine.Core.dll", "portable/WolEngine.Core.props"} editor = {"linux-x64": "editor/Godot_v4.7.2-stable_mono_linux.x86_64", "windows-x64": "editor/Godot_v4.7.2-stable_mono_win64.exe", "macos-universal": "editor/Godot.app/Contents/MacOS/Godot"}[target] @@ -150,7 +151,7 @@ def check_sdk(cls, archive, commit, target): raise cls.PolicyError("Nonempty C# implementation in SDK") if suffix in {".dll", ".exe"} and not data.startswith(b"MZ"): raise cls.PolicyError("Invalid PE binary") - if name.startswith("managed/"): + if suffix == ".dll" and name.startswith(("managed/", "portable/")): # Owned assemblies must not embed portable PDBs or CodeView paths. pe = struct.unpack_from("', 'GodotApi.props': b'', 'native/spatial.gdextension': b'[configuration]', f'native/bin/libspatial.{platform}.template_release.{arch}.{extension}': native, 'managed/Debug/WolEngine.dll': managed or self.pe, 'managed/Release/WolEngine.dll': managed or self.pe, + 'portable/WolEngine.Core.props': b'', 'portable/Debug/WolEngine.Core.dll': self.pe, 'portable/Release/WolEngine.Core.dll': self.pe, editor: native, 'runtime/PublicIdentity.cs': b'\n'} files.update(extra or {}) manifest = {'schema': 1, 'godot': '4.7.2', 'target': target, 'commit': self.commit, 'editor': editor, @@ -74,6 +75,21 @@ def test_embedded_symbols_and_private_source_in_dependency_packages_are_rejected with self.assertRaises(ValueError): SDKRelease.check_sdk(self.sdk(extra={'editor/GodotSharp/Tools/nupkgs/Godot.NET.Sdk.4.7.2.nupkg': nested.getvalue()}), self.commit, 'linux-x64') + def test_portable_core_uses_the_same_source_and_symbol_boundary(self): + for name, payload in [('portable/Release/WolEngine.Core.cs', b'namespace Wol.Engine;'), + ('portable/Release/WolEngine.Core.pdb', b'symbols'), + ('portable/Release/Extra.dll', self.pe), + ('portable/Release/WolEngine.Core.dll', b'source disguised as a DLL')]: + with self.subTest(name=name), self.assertRaises(ValueError): + SDKRelease.check_sdk(self.sdk(extra={name: payload}), self.commit, 'linux-x64') + pe = bytearray(self.pe) + bytearray(128) + struct.pack_into('