feat: Capacitor 8 compatibility: native refactor, unified API, and documentation update#80
Merged
Merged
Conversation
- Updated iOS Swift implementation to be fully compatible with Capacitor 8 (no promise rejection, unified success/error payload) - Refactored Android implementation for consistency with iOS and Capacitor 8 - Standardized TypeScript API and typings (success/error result) - Improved documentation using platform-appropriate standards (Swift DocC, JavaDoc, TSDoc) - Updated README to document Capacitor 8 behavior and limitations
- Added explicit documentation for Capacitor 8 breaking change regarding native promise handling (always resolve, return success/error payload) - Clarified behavior in README to avoid ambiguity for plugin consumers - Fixed linting and formatting issues across the codebase (ESLint, Prettier, SwiftLint)
Closed
|
Could you review this PR please? |
Owner
|
Hi, sorry for the wait. I will be looking at this PR in the next couple days. |
RaphaelWoude
requested changes
Jan 19, 2026
Owner
RaphaelWoude
left a comment
RaphaelWoude
left a comment
There was a problem hiding this comment.
One small comment about the breaking changes in the README.md.
Owner
|
Thanks for this. Going to do final testing tomorrow morning. |
Owner
|
Everything looks great. Thank you for your contribution once again |
Owner
|
Live in v8.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the plugin to be fully compatible with Capacitor 8 across iOS, Android, and TypeScript.
Main changes:
(no promise rejection, explicit success/error payloads).
This PR has been tested locally on both Android and iOS.
However, since this plugin interacts with system-level settings and behavior can vary
between devices and OS versions, it is strongly recommended that the original maintainer
also tests these changes in their own environment before approving and releasing.
No breaking changes are introduced beyond the already required Capacitor 8 migration.