fix: restore standard promise rejection and revert breaking error handling#81
Merged
Merged
Conversation
Owner
|
Hey, thanks for contributing again. I will take a look tomorrow night. |
Contributor
Author
The build fails... probably you need to update your CI... cap8 need xCode26+ |
Owner
|
Looking at it |
RaphaelWoude
approved these changes
Mar 17, 2026
Owner
RaphaelWoude
left a comment
RaphaelWoude
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your contribution once again. Much appreciated.
I will update the BREAKING changes MD again.
Owner
|
Live in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts the temporary error handling strategy introduced for Capacitor v8 and restores the standard Promise rejection behavior using
call.reject().The previous "breaking change" assumption—which forced all methods to resolve with a
{ success: false }object—was based on a known upstream issue with Swift Package Manager (capacitor-swift-pm #33). This issue is now resolved in the supported Capacitor v8 / Xcode 26 toolchain.Changes
resolveErrorpatterns with nativecall.reject()on both Android and iOS.try/catchblocks in JavaScript, aligning the plugin with Capacitor's normative architectural rules.successflags from result objects that were only used for error reporting.