Skip to content

pre-commit-ci checks fail with each PR due to errors detected by mypy, markdownlint and ruff #261

@sg-rh

Description

@sg-rh

Some of the pre-commit-ci checks fail due to formatting/ linting issues in various files in firewatch codebase.
We need to fix the issue by fixing those formatting.

check python ast.........................................................Passed
check for merge conflicts................................................Passed
debug statements (python)................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
fix requirements.txt.....................................................Passed
check docstring is first.................................................Passed
check json...............................................................Passed
check yaml...............................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

src/objects/job.py:493: error: Argument "failed_step" to "Failure" has incompatible type "Any | str | None"; expected "str"  [arg-type]
src/objects/job.py:494: error: Argument "failure_type" to "Failure" has incompatible type "Any | str | None"; expected "str"  [arg-type]
Found 2 errors in 1 file (checked 21 source files)

flake8...................................................................Passed
markdownlint-cli2........................................................Failed
- hook id: markdownlint-cli2
- exit code: 1

markdownlint-cli2 v0.18.1 (markdownlint v0.38.0)
Finding: README.md docs/cli_usage_guide.md docs/jira_escalation_tool_guide.MD docs/README.md
Linting: 4 file(s)
Summary: 0 error(s)
markdownlint-cli2 v0.18.1 (markdownlint v0.38.0)
Finding: tests/README.md docs/configuration_guide.md docs/contribution_guide.md
Linting: 3 file(s)
Summary: 1 error(s)
docs/configuration_guide.md:302:95 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"]

Detect secrets...........................................................Passed
ruff (legacy alias)......................................................Passed
ruff format..............................................................Failed
- hook id: ruff-format
- files were modified by this hook

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions