Audit finding: P4-QUAL-07 residual (P3) — see docs/audits/README.md (Pass 5 notes).
The contextcheck linter was deferred because the forge detection/PR chain (internal/forge, called from agent pr) does not thread a context.Context end-to-end, so subprocess calls there cannot be cancelled.
What to do
- Thread
context.Context from the agent pr command through the forge helpers to every exec.Command call site (make them exec.CommandContext).
- Enable
contextcheck in .golangci.yml and fix any remaining findings it raises.
- No behavior change expected; cancellation via Ctrl-C during
agent pr becoming effective is the win.
Gates: gofmt -w cmd internal, golangci-lint run, go test -race ./.... Spec-drift/work-log bookkeeping is advisory on fork PRs; the maintainer completes it at merge.
Audit finding:
P4-QUAL-07residual (P3) — seedocs/audits/README.md(Pass 5 notes).The
contextchecklinter was deferred because the forge detection/PR chain (internal/forge, called fromagent pr) does not thread acontext.Contextend-to-end, so subprocess calls there cannot be cancelled.What to do
context.Contextfrom theagent prcommand through the forge helpers to everyexec.Commandcall site (make themexec.CommandContext).contextcheckin.golangci.ymland fix any remaining findings it raises.agent prbecoming effective is the win.Gates:
gofmt -w cmd internal,golangci-lint run,go test -race ./.... Spec-drift/work-log bookkeeping is advisory on fork PRs; the maintainer completes it at merge.