Skip to content

Commit 8cf4294

Browse files
committed
Remove tests for plots based on snapshots for beeing too fragile
1 parent ee17630 commit 8cf4294

File tree

10 files changed

+28
-573975
lines changed

10 files changed

+28
-573975
lines changed

tests/testthat/Rplots.pdf

0 Bytes
Binary file not shown.

tests/testthat/_snaps/Linux/plots/mapping-water-depth.svg

Lines changed: 0 additions & 3 deletions
This file was deleted.

tests/testthat/_snaps/Linux/plots/plot-by-date.svg

Lines changed: 0 additions & 1073 deletions
This file was deleted.

tests/testthat/_snaps/Linux/plots/specifying-index.svg

Lines changed: 0 additions & 1073 deletions
This file was deleted.

tests/testthat/_snaps/Linux/plots/un-normalized-2d-spectra.svg

Lines changed: 0 additions & 1073 deletions
This file was deleted.

tests/testthat/_snaps/Windows/plots/mapping-water-depth.svg

Lines changed: 0 additions & 567514 deletions
This file was deleted.

tests/testthat/_snaps/Windows/plots/plot-by-date.svg

Lines changed: 0 additions & 1073 deletions
This file was deleted.

tests/testthat/_snaps/Windows/plots/specifying-index.svg

Lines changed: 0 additions & 1073 deletions
This file was deleted.

tests/testthat/_snaps/Windows/plots/un-normalized-2d-spectra.svg

Lines changed: 0 additions & 1073 deletions
This file was deleted.

tests/testthat/test-plots.R

Lines changed: 28 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,35 @@ test_that("we can plot the 2D spectrum", {
66
expect_no_warning(print(plot_from_index))
77
expect_no_warning(print(plot_not_normalized))
88
expect_no_warning(print(plot_from_date))
9-
vdiffr::expect_doppelganger(
10-
"Specifying index",
11-
plot_from_index,
12-
variant = Sys.info()[["sysname"]]
13-
)
14-
vdiffr::expect_doppelganger(
15-
"Un-normalized 2D spectra",
16-
plot_not_normalized,
17-
variant = Sys.info()[["sysname"]]
18-
)
19-
vdiffr::expect_doppelganger(
20-
"Plot by date",
21-
plot_from_date,
22-
variant = Sys.info()[["sysname"]]
23-
)
9+
# vdiffr::expect_doppelganger(
10+
# "Specifying index",
11+
# plot_from_index,
12+
# variant = Sys.info()[["sysname"]]
13+
# )
14+
# vdiffr::expect_doppelganger(
15+
# "Un-normalized 2D spectra",
16+
# plot_not_normalized,
17+
# variant = Sys.info()[["sysname"]]
18+
# )
19+
# vdiffr::expect_doppelganger(
20+
# "Plot by date",
21+
# plot_from_date,
22+
# variant = Sys.info()[["sysname"]]
23+
# )
2424
})
2525

2626
test_that("Plotting maps works", {
27-
vdiffr::expect_doppelganger(
28-
"Mapping water depth",
29-
rscd_mapplot(resourcecodedata::rscd_field$depth, name = "Depth (m)"),
30-
variant = Sys.info()[["sysname"]]
31-
)
27+
expect_no_error(rscd_mapplot(
28+
resourcecodedata::rscd_field$depth,
29+
name = "Depth (m)"
30+
))
31+
expect_no_warning(rscd_mapplot(
32+
resourcecodedata::rscd_field$depth,
33+
name = "Depth (m)"
34+
))
35+
# vdiffr::expect_doppelganger(
36+
# "Mapping water depth",
37+
# rscd_mapplot(resourcecodedata::rscd_field$depth, name = "Depth (m)"),
38+
# variant = Sys.info()[["sysname"]]
39+
# )
3240
})

0 commit comments

Comments
 (0)