Skip to content

Feature - A0xRouter - 0x swap fees removal #864

@gabririgo

Description

@gabririgo

The 0x api allows specifying swapFeeRecipient and swapFeeBps, with a maximum of 1000 bps. However, this fee defeats the principle that the pool operator cannot access pool's funds directly, because arbitrary fees could be used to empty the pool. The fee is encoded in the data field passed to the 0xSettler instance. This means we will have to decode the fee and assert it is null. This is a security enhancement, not a bug - because the pool operator is not fully trustless.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions