From 5d62b43afda2b746ff378d3156c352c979baa217 Mon Sep 17 00:00:00 2001 From: Harshit2405-2004 Date: Sat, 7 Mar 2026 03:33:05 +0530 Subject: [PATCH] fix(fuselage): remove unsafe value casts in Select components --- .changeset/select-types.md | 5 +++++ .../src/components/PaginatedSelect/PaginatedSelect.tsx | 2 +- packages/fuselage/src/components/Select/SelectLegacy.tsx | 4 ++-- 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/select-types.md diff --git a/.changeset/select-types.md b/.changeset/select-types.md new file mode 100644 index 0000000000..00457abdf8 --- /dev/null +++ b/.changeset/select-types.md @@ -0,0 +1,5 @@ +--- +'@rocket.chat/fuselage': patch +--- + +Remove unsafe SelectOption casting and widen the value type to string | number. diff --git a/packages/fuselage/src/components/PaginatedSelect/PaginatedSelect.tsx b/packages/fuselage/src/components/PaginatedSelect/PaginatedSelect.tsx index b8b207cb8e..57d08e9776 100644 --- a/packages/fuselage/src/components/PaginatedSelect/PaginatedSelect.tsx +++ b/packages/fuselage/src/components/PaginatedSelect/PaginatedSelect.tsx @@ -57,7 +57,7 @@ export const PaginatedSelect = ({ const internalChangedByClick = useStableCallback(([value]: OptionType) => { setInternalValue(value); - onChange(value as SelectOption[0]); // FIXME + onChange(value); // FIXME hide(); }); diff --git a/packages/fuselage/src/components/Select/SelectLegacy.tsx b/packages/fuselage/src/components/Select/SelectLegacy.tsx index ee72c52d02..157161b176 100644 --- a/packages/fuselage/src/components/Select/SelectLegacy.tsx +++ b/packages/fuselage/src/components/Select/SelectLegacy.tsx @@ -86,7 +86,7 @@ const SelectLegacy = forwardRef( const internalChangedByKeyboard = useStableCallback( ([value]: OptionType) => { setInternalValue(value); - onChange(value as SelectOption[0]); // FIXME + onChange(value); // FIXME }, ); @@ -121,7 +121,7 @@ const SelectLegacy = forwardRef( const internalChangedByClick = useStableCallback(([value]: OptionType) => { setInternalValue(value); - onChange(value as SelectOption[0]); // FIXME + onChange(value); // FIXME removeFocusClass(); hide(); });