From 731099de7230f00bb937bbef95d995b80874fcba Mon Sep 17 00:00:00 2001 From: Shubham Srivastava <151642061+ShubhamS2005@users.noreply.github.com> Date: Sat, 21 Mar 2026 13:39:55 +0000 Subject: [PATCH] fix(checkbox): remove unsupported prop and clean up storybook --- .../src/components/CheckBox/CheckBox.stories.tsx | 3 +++ .../src/components/CheckBox/CheckBox.tsx | 16 ++++++++-------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/packages/fuselage/src/components/CheckBox/CheckBox.stories.tsx b/packages/fuselage/src/components/CheckBox/CheckBox.stories.tsx index 32c0497ae0..3a76e2f1a5 100644 --- a/packages/fuselage/src/components/CheckBox/CheckBox.stories.tsx +++ b/packages/fuselage/src/components/CheckBox/CheckBox.stories.tsx @@ -11,6 +11,9 @@ import CheckBox from './CheckBox'; export default { title: 'Inputs/CheckBox', component: CheckBox, + argTypes: { + is: { table: { disable: true } }, + }, } satisfies Meta; const Template: StoryFn = (args) => ( diff --git a/packages/fuselage/src/components/CheckBox/CheckBox.tsx b/packages/fuselage/src/components/CheckBox/CheckBox.tsx index 30e2916a75..cd45622b36 100644 --- a/packages/fuselage/src/components/CheckBox/CheckBox.tsx +++ b/packages/fuselage/src/components/CheckBox/CheckBox.tsx @@ -17,35 +17,35 @@ const CheckBox = forwardRef(function CheckBox( const mergedRef = useMergedRefs(ref, innerRef); useLayoutEffect(() => { - if (innerRef && innerRef.current && indeterminate !== undefined) { + if (innerRef.current && indeterminate !== undefined) { innerRef.current.indeterminate = indeterminate; } - }, [innerRef, indeterminate]); + }, [indeterminate]); const handleChange = useCallback( (event: FormEvent) => { - if (innerRef && innerRef.current && indeterminate !== undefined) { + if (innerRef.current && indeterminate !== undefined) { innerRef.current.indeterminate = indeterminate; } onChange?.call(innerRef.current, event); }, - [innerRef, indeterminate, onChange], + [indeterminate, onChange], ); return ( - + {labelChildren} -