From 45d79d47123fa682eee5d870214b1f82c6fa79cc Mon Sep 17 00:00:00 2001 From: Roland Salardon Date: Sat, 15 Aug 2026 20:26:28 +0200 Subject: [PATCH 1/3] fix(rotation): add missing finders for Shale Storm, Relic of Sorrow, Unnatural Traversal, Shattered Aegis - Shale Storm (72906): BuffGainCastFinder for ShaleStormBuff (72996) and ShaleStormSecondaryAttackBuff (79373) - Relic of Sorrow (74410): EffectCastFinder with RelicOfSorrow1/2/3 effect GUIDs - Unnatural Traversal (63195): EffectCastFinderByDst with UntamedUnnaturalTraversal effect GUID - Shattered Aegis (22499): DamageCastFinder with 50ms ICD These address missing rotation casts in the corpus. Signed-off-by: Roland Salardon --- libs/gw2_analytics/src/gw2_analytics/rotation.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libs/gw2_analytics/src/gw2_analytics/rotation.py b/libs/gw2_analytics/src/gw2_analytics/rotation.py index 7aa91c85..a3d66465 100644 --- a/libs/gw2_analytics/src/gw2_analytics/rotation.py +++ b/libs/gw2_analytics/src/gw2_analytics/rotation.py @@ -126,6 +126,8 @@ 9123: 9082, # Shield of Wrath 10582: 10583, # Spectral Armor 62919: 62749, # Legendary Alliance Stance + 72996: 72906, # Shale Storm buff -> Shale Storm skill + 79373: 72906, # Shale Storm Secondary Attack buff -> Shale Storm skill } _BUFF_LOSS_CASTS = { 29446: 30961, @@ -201,6 +203,7 @@ 31658: 50, # Glyph of Equality 5572: 50, # Signet of Air (damage path; + effect-by-dst below) 76315: 50, # Bloodstone Explosion + 22499: 50, # Shattered Aegis } _DAMAGE_CASTS_BY_DAMAGE = {40071: 44428, 46808: 40813} _HEALING_CASTS = { @@ -335,6 +338,10 @@ "13D0B65D73B5334D80824EE17B5C257E": 13677, "FB78801BB31CAF488B55F2F57EF9B070": 78837, "842F977C318FDC4F96C99C385C1D0672": 76613, # Symbiotic Shielding + "3D981397D9C6A44B888212CE4E3F6F9A": 74410, # Relic of Sorrow + "DB02EB39ABBEE241859DC9662AD49FA5": 74410, # Relic of Sorrow + "FEEA4632BAF0B1438D83F6C8B71AEA15": 74410, # Relic of Sorrow + "8D36806A690A5442A983308EDCECB018": 63195, # Unnatural Traversal "4A83F0B627B75C47894941C4D35BA89F": 78604, "03850757F14FD44A9998D4CAD71CC589": 78358, "611D90C69ECF8142BEEE84139F333388": 30101, @@ -459,11 +466,12 @@ "9242D10B4F04274EB6E9EBCDB2262181": 77213, "B02D3D0FF0A4FC47B23B1478D8E770AE": -29, "30A96C0E559DBD489FEE36DA96CC374A": 5572, # Signet of Air - "23284B87C26C9A41A887F410F930E1A2": 13064, # Infiltrator's Signet +"23284B87C26C9A41A887F410F930E1A2": 13064, # Infiltrator's Signet "BB5488951B60B546BB1BD5626DAE83E1": 13062, # Signet of Agility "418A090D719AB44AAF1C4AD1473068C4": 43176, # Flash Spark - "D7F8FA5695F8714B99A51EE72EF6E178": 14413, # Dolyak Signet + "D7F8FA5695F8714B99A5C3EE72EF6E178": 14413, # Dolyak Signet "68F2C378E6C80548B5A3C89870C5DD86": 9085, # "Save Yourselves!" + "8D36806A690A5442A983308EDCECB018": 63195, # Unnatural Traversal } _SECONDARY_EFFECTS = { _MECHANIST_SHIFT_SIGNET_EFFECT: (_MECHANIST_SHIFT_SIGNET_SELF_EFFECT,), From 8319b1bdd19f48c4e1843dbd6ac4d82dff231bb1 Mon Sep 17 00:00:00 2001 From: Roland Salardon Date: Sat, 15 Aug 2026 20:38:18 +0200 Subject: [PATCH 2/3] fix(rotation): fix duplicate key 22499 in _DAMAGE_CASTS dict Signed-off-by: Roland Salardon --- libs/gw2_analytics/src/gw2_analytics/rotation.py | 1 - 1 file changed, 1 deletion(-) diff --git a/libs/gw2_analytics/src/gw2_analytics/rotation.py b/libs/gw2_analytics/src/gw2_analytics/rotation.py index a3d66465..4bedb975 100644 --- a/libs/gw2_analytics/src/gw2_analytics/rotation.py +++ b/libs/gw2_analytics/src/gw2_analytics/rotation.py @@ -203,7 +203,6 @@ 31658: 50, # Glyph of Equality 5572: 50, # Signet of Air (damage path; + effect-by-dst below) 76315: 50, # Bloodstone Explosion - 22499: 50, # Shattered Aegis } _DAMAGE_CASTS_BY_DAMAGE = {40071: 44428, 46808: 40813} _HEALING_CASTS = { From a405c3ec43e7d70d985a46c1932d84bef0f83c69 Mon Sep 17 00:00:00 2001 From: Roland Salardon Date: Sat, 15 Aug 2026 21:14:13 +0200 Subject: [PATCH 3/3] style(rotation): ruff format Signed-off-by: Roland Salardon --- libs/gw2_analytics/src/gw2_analytics/rotation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/gw2_analytics/src/gw2_analytics/rotation.py b/libs/gw2_analytics/src/gw2_analytics/rotation.py index 4bedb975..636069df 100644 --- a/libs/gw2_analytics/src/gw2_analytics/rotation.py +++ b/libs/gw2_analytics/src/gw2_analytics/rotation.py @@ -465,7 +465,7 @@ "9242D10B4F04274EB6E9EBCDB2262181": 77213, "B02D3D0FF0A4FC47B23B1478D8E770AE": -29, "30A96C0E559DBD489FEE36DA96CC374A": 5572, # Signet of Air -"23284B87C26C9A41A887F410F930E1A2": 13064, # Infiltrator's Signet + "23284B87C26C9A41A887F410F930E1A2": 13064, # Infiltrator's Signet "BB5488951B60B546BB1BD5626DAE83E1": 13062, # Signet of Agility "418A090D719AB44AAF1C4AD1473068C4": 43176, # Flash Spark "D7F8FA5695F8714B99A5C3EE72EF6E178": 14413, # Dolyak Signet