From 93772a4157daaec85712e3142f18f11e8d0f044f Mon Sep 17 00:00:00 2001
From: "@daniel-lxs" <57051444+daniel-lxs@users.noreply.github.com>
Date: Mon, 7 Sep 2026 01:54:12 +0000
Subject: [PATCH] fix: name the pull request delivery control for accessibility

---
 .../src/components/settings/SourceControl.test.tsx   | 12 ++++++++++--
 apps/web/src/components/settings/SourceControl.tsx   |  5 ++++-
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/apps/web/src/components/settings/SourceControl.test.tsx b/apps/web/src/components/settings/SourceControl.test.tsx
index ea1d1ba0e..7fc9acbaf 100644
--- a/apps/web/src/components/settings/SourceControl.test.tsx
+++ b/apps/web/src/components/settings/SourceControl.test.tsx
@@ -307,8 +307,13 @@ vi.mock('@/components/system', () => ({
   SelectItem: ({ children, value }: { children: ReactNode; value: string }) => (
     <div data-value={value}>{children}</div>
   ),
-  SelectTrigger: ({ children }: { children: ReactNode }) => (
-    <div>{children}</div>
+  SelectTrigger: ({
+    children,
+    ...props
+  }: ButtonHTMLAttributes<HTMLButtonElement>) => (
+    <button type="button" role="combobox" {...props}>
+      {children}
+    </button>
   ),
   SelectValue: () => <span />,
   Settings2: (props: SVGProps<SVGSVGElement>) => (
@@ -613,6 +618,9 @@ describe('SourceControl settings', () => {
     render(<SourceControl />);
 
     expect(screen.getByText('Pull request delivery')).toBeInTheDocument();
+    expect(
+      screen.getByRole('combobox', { name: 'Pull request delivery' }),
+    ).toBeInTheDocument();
     expect(screen.getByTestId('pr-action-select')).toHaveAttribute(
       'data-value',
       'draft',
diff --git a/apps/web/src/components/settings/SourceControl.tsx b/apps/web/src/components/settings/SourceControl.tsx
index 2b2be6b5c..548848205 100644
--- a/apps/web/src/components/settings/SourceControl.tsx
+++ b/apps/web/src/components/settings/SourceControl.tsx
@@ -563,7 +563,10 @@ function PrActionSetting({
         }}
         disabled={prActionQuery.isLoading || setPrAction.isPending}
       >
-        <SelectTrigger className="w-full max-w-sm">
+        <SelectTrigger
+          aria-label="Pull request delivery"
+          className="w-full max-w-sm"
+        >
           <SelectValue placeholder="Select a delivery mode" />
         </SelectTrigger>
         <SelectContent>