Skip to content

Windows installer not produced by mach package #369

Description

@tmbrbr

Windows installer not produced by mach package

Describe the bug

The GitHub Actions workflow uploads the Windows build artifact from:

obj-tf-release/dist/install/sea/foxhound-*.en-US.win64.installer.exe

This path no longer exists. It was removed upstream in Bug 1970692 ("Get rid of install/sea"), which landed between
Firefox 140 and 149.

Additionally, mach package only produces a .zip archive (dist/foxhound-*.en-US.win64.zip). The .installer.exe requires a separate mach repackage installer step that
is not currently in the workflow.

Steps to reproduce

Run the Windows CI build — the "Upload Artifacts" step will silently upload nothing because the glob matches no files.

Expected behavior

A foxhound-*.en-US.win64.installer.exe artifact is uploaded after a successful Windows build.

Also see: https://github.com/SAP/project-foxhound/actions/runs/26110426051/job/76785878361

Run actions/upload-artifact@v4
Warning: No files were found with the provided path: obj-tf-release/dist/install/sea/foxhound-*.en-US.win64.installer.exe. No artifacts will be uploaded.

Fix

Two changes are needed in .github/workflows/browser.yml:

  1. Add a mach repackage installer step after mach package, passing the produced .zip as input.
  2. Update the artifact upload path to obj-tf-release/dist/foxhound-*.en-US.win64.installer.exe.

Metadata

Metadata

Assignees

No one assigned

    Labels

    githubAnything related to github actions

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions