v1.3: removed EndTransmission after RequestFrom & delay between retries is now set to 1ms

Author: SMFSW

Doxyfile

@@ -770,7 +770,7 @@ WARN_FORMAT            = "$file:$line: $text"
 # messages should be written. If left blank the output is written to standard
 # error (stderr).
 
-WARN_LOGFILE           = doxy.log
+WARN_LOGFILE           = workdir/doxy.log
 
 #---------------------------------------------------------------------------
 # Configuration options related to the input files

ReleaseNotes.md

@@ -13,7 +13,9 @@ Feel free to share your thoughts @ xgarmanboziax@gmail.com about:
 ------------
 
 ** Actual:
-v1.3	3 May 2018:
+v1.3	13 May 2018:
+- Removed call to endTramsission after requestFrom
+- Delay between retries is now 1ms
 - Adding support for unit tests and doxygen documentation generation with Travis CI
 - Updated README.md
 

examples/wirewrapper_advanced/wirewrapper_advanced.ino

@@ -7,7 +7,7 @@
 	This example code is in the public domain.
 
 	created Jan 23 2017
-	latest mod Nov 30 2017
+	latest mod May 13 2018
 	by SMFSW
 */
 
@@ -113,15 +113,14 @@ bool I2C_rd_advanced(I2C_SLAVE * slave, const uint16_t reg_addr, uint8_t * data,
 		if (Wire.write((uint8_t) reg_addr) == 0)					{ return false; }
 		if (Wire.endTransmission(false) != 0)						{ return false; }
 	}
+
 	if (Wire.requestFrom((int) slave->cfg.addr, (int) bytes) == 0)	{ return false; }
 	for (uint16_t cnt = 0; cnt < bytes; cnt++)
 	{
 		*data++ = Wire.read();
 		slave->reg_addr++;
 	}
 
-	if (Wire.endTransmission() != 0)								{ return false; }
-
 	return true;
 }
 
@@ -144,7 +143,6 @@ bool I2C_get_chip_id(I2C_SLAVE * slave, uint8_t * data)
 	if (Wire.requestFrom((int) FRAM_ID.cfg.addr, (int) bytes) == 0)	{ return false; }
 	for (uint16_t cnt = 0; cnt < bytes; cnt++)
 	{ *data++ = Wire.read(); }
-	if (Wire.endTransmission() != 0)								{ return false; }
 
 	return true;
 }

src/WireWrapper.cpp

@@ -1,7 +1,7 @@
 /*!\file WireWrapper.cpp
 ** \author SMFSW
-** \copyright MIT SMFSW (2017)
-** \brief Arduino Wrapper for Wire librarry (for SAM, ESP8266...) code
+** \copyright MIT SMFSW (2017-2018)
+** \brief Arduino Wrapper for Wire library (for SAM, ESP8266...) code
 ** \warning Don't access (r/w) last 16b internal address byte alone right after init, this would lead to hazardous result (in such case, make a dummy read of addr 0 before)
 **/
 
@@ -177,7 +177,7 @@ static I2C_STATUS I2C_comm(I2C_SLAVE * slave, const uint16_t reg_addr, uint8_t *
 	ack = fc(slave, reg_addr, data, bytes);
 	while ((!ack) && (retry != 0))	// If com not successful, retry some more times
 	{
-		delay(5);
+		delay(1);
 		ack = fc(slave, reg_addr, data, bytes);
 		retry--;
 	}
@@ -266,14 +266,13 @@ static bool I2C_rd(I2C_SLAVE * slave, const uint16_t reg_addr, uint8_t * data, c
 		if (Wire.write((uint8_t) reg_addr) == 0)					{ return false; }
 		if (Wire.endTransmission(false) != 0)						{ return false; }
 	}
+
 	if (Wire.requestFrom((int) slave->cfg.addr, (int) bytes) == 0)	{ return false; }
 	for (uint16_t cnt = 0; cnt < bytes; cnt++)
 	{
 		*data++ = Wire.read();
 		slave->reg_addr++;
 	}
 
-	if (Wire.endTransmission() != 0)								{ return false; }
-
 	return true;
 }

src/WireWrapper.h

@@ -1,7 +1,7 @@
 /*!\file WireWrapper.h
 ** \author SMFSW
-** \copyright MIT SMFSW (2017)
-** \brief Arduino Wrapper for Wire librarry (for SAM, ESP8266...) declarations
+** \copyright MIT SMFSW (2017-2018)
+** \brief Arduino Wrapper for Wire library (for SAM, ESP8266...) declarations
 ** \warning Don't access (r/w) last 16b internal address byte alone right after init, this would lead to hazardous result (in such case, make a dummy read of addr 0 before)
 **/
 /****************************************************************/