From 6b594f78b99cf96f059051d3d0e99cda9070deae Mon Sep 17 00:00:00 2001 From: Mikkel Wendt-Larsen Date: Fri, 15 Mar 2013 22:54:54 +0100 Subject: [PATCH 1/2] Added maven failsafe plugin to sonos-root. Added the Maven Failsafe Plugin to run Integration Tests. UnitTest which require external devices is moved to integration-test phase. --- .../sonos/{CLITestCase.java => ClientIT.java} | 2 +- .../sonos/{ClingTestCase.java => ClingIT.java} | 2 +- sonos-root/pom.xml | 14 +++++++++++++- 3 files changed, 15 insertions(+), 3 deletions(-) rename sonos-java/src/test/java/org/tensin/sonos/{CLITestCase.java => ClientIT.java} (99%) rename sonos-java/src/test/java/org/tensin/sonos/{ClingTestCase.java => ClingIT.java} (99%) diff --git a/sonos-java/src/test/java/org/tensin/sonos/CLITestCase.java b/sonos-java/src/test/java/org/tensin/sonos/ClientIT.java similarity index 99% rename from sonos-java/src/test/java/org/tensin/sonos/CLITestCase.java rename to sonos-java/src/test/java/org/tensin/sonos/ClientIT.java index 2fa3057..96eb503 100644 --- a/sonos-java/src/test/java/org/tensin/sonos/CLITestCase.java +++ b/sonos-java/src/test/java/org/tensin/sonos/ClientIT.java @@ -17,7 +17,7 @@ /** * The Class CLITestCase. */ -public class CLITestCase { +public class ClientIT { /** The zone command dispatcher. */ private final ZoneCommandDispatcher zoneCommandDispatcher = ZoneCommandDispatcher.getInstance(); diff --git a/sonos-java/src/test/java/org/tensin/sonos/ClingTestCase.java b/sonos-java/src/test/java/org/tensin/sonos/ClingIT.java similarity index 99% rename from sonos-java/src/test/java/org/tensin/sonos/ClingTestCase.java rename to sonos-java/src/test/java/org/tensin/sonos/ClingIT.java index 8c7b2e4..ee96aca 100644 --- a/sonos-java/src/test/java/org/tensin/sonos/ClingTestCase.java +++ b/sonos-java/src/test/java/org/tensin/sonos/ClingIT.java @@ -13,7 +13,7 @@ /** * The Class ClingTestCase. */ -public class ClingTestCase { +public class ClingIT { /** * Test discovery. diff --git a/sonos-root/pom.xml b/sonos-root/pom.xml index c7d8392..fe7fb59 100644 --- a/sonos-root/pom.xml +++ b/sonos-root/pom.xml @@ -104,7 +104,19 @@ compile - + + org.apache.maven.plugins + maven-failsafe-plugin + 2.12.4 + + + + integration-test + verify + + + + maven-eclipse-plugin 2.8 From df92a0f023452cb56e68c6171d174b5ebc649150 Mon Sep 17 00:00:00 2001 From: Mikkel Wendt-Larsen Date: Thu, 11 Apr 2013 21:20:31 +0200 Subject: [PATCH 2/2] Rewrote sonos-java dist assembly Rewrote sonos-java assembly to include all dependencies(including itself) in the lib directory, and the launcher to the root directory. No need for "mvn clean dependency:copy-dependencies install assembly:assembly -Dmaven.test.skip=true" anymore, it is now done with "mvn clean package". changes in manifest: - Addded classpath "same as sonos-java.*.jar" - Mainclass changed to "org.tensin.sonos.commander.CLIController" --- sonos-java/pom.xml | 24 ++++---- sonos-java/src/build/distrib.xml | 58 +++++++------------ .../tensin/sonos/commander/CLIController.java | 3 + 3 files changed, 36 insertions(+), 49 deletions(-) diff --git a/sonos-java/pom.xml b/sonos-java/pom.xml index 2fcd996..ce85245 100644 --- a/sonos-java/pom.xml +++ b/sonos-java/pom.xml @@ -51,12 +51,16 @@ src/build/distrib.xml - - - - false - + + + make-assembly + package + + single + + + @@ -64,13 +68,11 @@ maven-jar-plugin - - org.tensin.sonos.run.Sonos - + + true + org.tensin.sonos.commander.CLIController + - - **/*.java - diff --git a/sonos-java/src/build/distrib.xml b/sonos-java/src/build/distrib.xml index b44a0f2..715619a 100644 --- a/sonos-java/src/build/distrib.xml +++ b/sonos-java/src/build/distrib.xml @@ -1,40 +1,22 @@ - dist - - zip - - - - - target/dependency/ - lib/ - - *.jar - - - - - target/ - lib/ - - *.jar - - - *-javadoc.jar - *-sources.jar - - - - - src/script - . - - *.sh - - - deploy.sh - - - - \ No newline at end of file + dist + + zip + tar.gz + + + + src/script/sonos.sh + / + + + + + + true + lib/ + runtime + + + diff --git a/sonos-java/src/main/java/org/tensin/sonos/commander/CLIController.java b/sonos-java/src/main/java/org/tensin/sonos/commander/CLIController.java index a824b00..4235f54 100644 --- a/sonos-java/src/main/java/org/tensin/sonos/commander/CLIController.java +++ b/sonos-java/src/main/java/org/tensin/sonos/commander/CLIController.java @@ -58,6 +58,9 @@ public static SystemHelper getSystemHelper() { * the sonos exception */ public static void main(final String args[]) throws SonosException { + // CLINQ library is not compatible with IPv6 stack + // (which is, by the way, for example the default in recent archlinux distributions) + System.setProperty("java.net.preferIPv4Stack", "true"); final CLIController a = createController(); a.start(args); }