removing `TYPE_FOOD` from cron

[vendz]

aashray-backend/cron.js

Line 68 in f24b2b9

if (bookingType == TYPE_FOOD) {

Can we directly use:

if (bookingType == TYPE_BREAKFAST || bookingType == TYPE_LUNCH || bookingType == TYPE_DINNER ) {

[ajain0184]

we can, but what would we return from getBookingTypeFromBooking(booking) method in booking.helper.js ?

[vendz]

There are two ways we can do this:

1. We remove TYPE_FOOD wherever used. and send original types back, which means we can basically remove that function since the whole purpose of that function was just to map food bookings
2. We start using TYPE_FOOD everywhere, which is a little bit cleaner but will require a lot of refactoring and adding an unnecessary layer of mapping

[ajain0184]

Ok. Let's do 1 then, and remove TYPE_FOOD from everywhere. Let's open a ticket on notion for this?

[pallavisavla]

we will also have to fix the data in database?